Jump to: navigation, search

Puppet

(Redirected from Puppet-openstack)

Introduction

The Puppet modules for OpenStack are written as a collaborative effort between OpenStack operators using Puppet.

Puppet Modules

Puppet OpenStack modules are part of OpenStack and most have moved under the OpenStack big tent. Some modules (like ceph) remain in the stackforge namespace.

The following Puppet modules exist:

Library repository, used for common resources accross all modules:

Optional tools that can be used in composition layer and might be helpful to deploy OpenStack:

Blueprints/specs repository:

Branches

The master branch of each modules corresponds to the latest packages available in upstream repositories. So if you submit a patch in master, it should pass beaker jobs that rely on upstream packaging (RDO in CentOS7 and UCA in Ubuntu Trusty).

For example, the current master branch of stackforge/puppet-keystone is targeting OpenStack Kilo, once released, a new stable/kilo branch will be created, from that point onward the master branch should target the OpenStack L release.

Releases

Master version of the modules will be released as a new major version to Puppet Forge (forge.puppetlabs.com) when its related version of OpenStack is released.

Each version of OpenStack have a corresponding release on the forge.

Module Version OpenStack Version OpenStack Version Codename Supported
2.y.z 2013.1.x Grizzly No
3.y.z 2013.2.x Havana No
4.y.z 2014.1.x Icehouse Yes
5.z.y 2014.2.x Juno Yes
6.z.y 2015.1.x Kilo Yes
7.z.y 2015.2.x Liberty Yes (current master)

Supported Platforms

The following OS/version are supported by the Puppet modules:

  • Fedora 18 / 19 / 20 / 21 / 22
  • RHEL 6.4 / 6.5 / 7
  • Ubuntu 12.04 (Precise) / 14.04 (Trusty)
  • Debian 7.0 (Wheezy) / Debian 8.0 (Jessie)

The modules have been primarily tested on Puppet 2.7.x and Ruby 1.8.7, although they are also being used with Puppet 3.1.x, 3.0.x, with Ruby 1.9.3.

Puppet 2.6.x is currently NOT supported, it has been EOL'ed by PuppetLabs.

Getting Help

Mailing list

In general, the mailing list is preferred, because it makes the information more readily available so that others who have the same question can search for and find those answers.

IRC

You can talk to us directly in IRC on the #puppet-openstack channel. (freenode.net)

IRC logs can be found here.

Reporting bugs

We are using Launchpad for bugs and features tracking. Issues and requests should be submitted under the OpenStack Puppet Modules project.

Developer documentation

Contributing to the modules

Getting Started

We follow the same process as all of the other OpenStack projects.

To contribute, the following docs contain enough information to get started:

Build new modules

If you want to create a new Puppet module for an OpenStack component, please follow this process https://wiki.openstack.org/wiki/Puppet/New_module

How code gets merged

Code is merged based on the voting process of the modules in Gerrit. All submitted patches automatically trigger a job that runs its rspec-puppet tests. This job is considered to be a gate in that no code is allowed to be merged that does not pass these tests. The results of this job are listed for every patch as a +1 Verified vote from Jenkins.

Any users can +/- 1 a commit and add comments on commit, but only members of the puppet-manager-core group have the ability to +2 and approve code to be merged.

Continuous Integration

Our modules are running CI that test different things against a patch. You can read more about how our CI works here: Puppet/CI.

Patches

Patches waiting to be merged can be viewed in Gerrit e.g. for openstack/puppet-keystone

https://review.openstack.org/#/q/status:open+project:openstack/puppet-keystone,n,z

Q. How do I go about submitting a patch for a released branch, what the correct process? Unless is not relevant all patches should be approved for the master branch before you submit them for a stable branch. This ensures we maintain stability in the stable branches and functionality

Downloading a local patch

Clone the relevant module from openstack, ex:

    git clone git://github.com/openstack/puppet-keystone

in the patch, find the git checkout or cherry-pick command, and copy it:

    git fetch https://review.openstack.org/openstack/puppet-keystone refs/changes/52/29452/9 && git checkout FETCH_HEAD

if you wanted to update an existing patch:

make a topic branch:

   git checkout -b my_topic

make your changes:

   hack,hack,hack

amend the current commit:

   git commit --amend .

now resubmit:

   git review

Rspec puppet tests

Rspec puppet tests are a requirement for getting code merged into the OpenStack puppet modules.

The best reference for getting started with rspec-puppet can be found here

For a new puppet openstack project, please see this page

Running local tests

The following command can invoked from any if the modules' directories to run their rspec puppet tests.

It assumes that both bundler as well as rubygems (and ruby) are already installed on the system.

mkdir vendor
export GEM_HOME=vendor
bundle install
# bundle exec rake -T
bundle exec rake spec

This relies on the file .fixtures.yaml to install all of the external module required for testing. The urls in this file use the git:// protocol, so this may need to be updated if you are behind a proxy.

Patch abandonment policy

If a change is submitted and given a -1, and subsequently the author becomes unresponsive for a few weeks, reviewers should leave reminder comments on the review or attempt to contact the original author via IRC or email. If the change is easy to fix, anyone should feel welcome to check out the change and resubmit it using the same change ID to preserve original authorship. Core reviewers will not abandon such a change.

If a change is submitted and given a -2, or it otherwise becomes clear that the change can not make it in (for example, if an alternate change was chosen to solve the problem), and the author has been unresponsive for at least 3 months, a core reviewer should abandon the change.

This policy is subject to change as we review our bandwidth for taking up forgotten patches and monitor our backlog growth.

stable branches

Master of the modules should be targeting the trunk of openstack as soon as a release is announced.

When this happens, a stable branch is created for any previous releases.

   ie: stable/kilo

It is the responsibility for the patch submitted to know if their patch should be backported to previous stable branches.


The general process for this can be found here: https://wiki.openstack.org/wiki/StableBranch#Workflow

create a stable branch

For branching you just go to the project page on Gerrit and make a new branch under the branches option.

Example https://review.openstack.org/#/admin/projects/stackforge/puppet-nova,branches

When you first create it it doesn't really appear in git until the first commit gets pushed to it or master.

Gerrit Dashboard

We use gerrit-dash-creator and this file to generate our dashboard (on OpenStack modules puppet)

Weekly meetings

Please see