Difference between revisions of "Nova/VersionedNotificationTransformation"

Revision as of 13:27, 2 June 2016

Goal

Transform every legacy notification to the new versioned notification framework.

How to do it

Check the notification devref that describes the new framework: http://docs.openstack.org/developer/nova/notifications.html
Check the existing new versioned notification example: https://review.openstack.org/#/c/245678/
Check the example transformation patch: https://review.openstack.org/#/c/313654/
Select a task for the below table and add your IRC handle to table. (Please take only one at a time)
Propose a transformation patch based on the examples.
If you got stuck you can ask questions from rlrossit and gibi on IRC or join the weekly notification subteam meeting https://wiki.openstack.org/wiki/Meetings/NovaNotification

Tasks

The easy ones that uses the same payload as instance.delete:

event type	status	taken by	review	comments
instance.delete	subteam review	gibi	https://review.openstack.org/#/c/313654	This shall be the base of for the other instance.<action> transformation
instance.shutdown	open
instance.scheduled	open
instance.create_ip	open
instance.delete_ip	open
instance.evacuate	open
instance.migration	open
instance.pause	open
instance.unpause	open
instance.power_on	open
instance.power_off	open
instance.reboot	open
instance.shelve	open
instance.shelve_offload	open
instance.unshelve	open
instance.snapshot	open
instance.soft_delete	open
instance.suspend	open
instance.resume	open
instance.restore	open
instance.trigger_crash_dump	open
instance.unrescue	open
instance.create	open			Some of the instance.create.<phase> notifications has extra payload
instance.rebuild	open
instance.rebuild.scheduled	open			we might need to change the event_type
instance.resize	open
instance.resize.prep	open			we might need to change the event_type
instance.finish_resize	open			we might want to change the even_type
instance.resize.confirm	open
instance.resize.revert	open
instance.live.migration.abort	open			we might need to change the even_type to make it consistent
instance.live_migration.pre	open			we might want to change the event_type
instance.live_migration.rollback.dest	open			we might want to change the event_type
instance.live_migration._rollback	open			we might want to change the event_type
instance.live_migration._post	open			we might want to change the even_type
instance.live_migration.post.dest	open			we might want to change the event_type

The complex instance.<action> notifications that needs payload extension.

event type	status	taken by
instance.update	needs patch	gibi
instance.exists	open
instance.rescue	open
instance.volume.attach	open

The rest:

event type	status	taken by	review	comments
aggregate.addhost	open
aggregate.create	open
aggregate.delete	open
aggregate.removehost	open
aggregate.updatemetadata	open
aggregate.updateprop	open
api.fault	open
libvirt.error	open
compute_task.build_instances	open
compute_task.migrate_server	open
compute_task.rebuild_server	open
HostAPI.power_action	open
HostAPI.set_enabled	open
HostAPI.set_maintenance	open
keypair.create	???
keypair.delete	???
keypair.import	???
network.floating_ip.allocate	open
network.floating_ip.associate	open
network.floating_ip.deallocate	open
network.floating_ip.disassociate	open
scheduler.select_destinations	open
servergroup.addmember	open
servergroup.create	open
servergroup.delete	open
volume.usage	open

@@ Line 111: / Line 111: @@
 ! event type !! status !! taken by !! review !! comments
 |-
-| Example || Example || Example || Example || Example
+| aggregate.addhost || open ||  ||  ||
 |-
-| Example || Example || Example || Example || Example
+| aggregate.create || open ||  ||  ||
 |-
-| Example || Example || Example || Example || Example
+| aggregate.delete || open ||  ||  ||
 |-
-| Example || Example || Example || Example || Example
+| aggregate.removehost || open ||  ||  ||
 |-
-| Example || Example || Example || Example || Example
+| aggregate.updatemetadata || open ||  ||  ||
 |-
-| Example || Example || Example || Example || Example
+| aggregate.updateprop || open ||  ||  ||
 |-
-| Example || Example || Example || Example || Example
+| api.fault || open ||  ||  ||
 |-
-| Example || Example || Example || Example || Example
+| libvirt.error || open ||  ||  ||
 |-
-| Example || Example || Example || Example || Example
+| compute_task.build_instances || open ||  ||  ||
 |-
-| Example || Example || Example || Example || Example
+| compute_task.migrate_server || open ||  ||  ||
 |-
-| Example || Example || Example || Example || Example
+| compute_task.rebuild_server || open ||  ||  ||
 |-
-| Example || Example || Example || Example || Example
+| HostAPI.power_action || open ||  ||  ||
 |-
-| Example || Example || Example || Example || Example
+| HostAPI.set_enabled || open ||  ||  ||
 |-
-| Example || Example || Example || Example || Example
+| HostAPI.set_maintenance || open ||  ||  ||
 |-
-| Example || Example || Example || Example || Example
+| keypair.create || ??? ||  ||  ||
+|-
+| keypair.delete || ??? ||  ||  ||
+|-
+| keypair.import || ??? ||  ||  ||
+|-
+| network.floating_ip.allocate || open ||  ||  ||
+|-
+| network.floating_ip.associate || open ||  ||  ||
+|-
+| network.floating_ip.deallocate || open ||  ||  ||
+|-
+| network.floating_ip.disassociate || open ||  ||  ||
+|-
+| scheduler.select_destinations || open ||  ||  ||
+|-
+| servergroup.addmember || open ||  ||  ||
+|-
+| servergroup.create || open ||  ||  ||
+|-
+| servergroup.delete || open ||  ||  ||
+|-
+| volume.usage || open ||  ||  ||
 |}