Difference between revisions of "Nova/VersionedNotificationTransformation"
< Nova
(→Follow up tasks) |
(→Tasks) |
||
Line 30: | Line 30: | ||
| instance.scheduled || open|| || || | | instance.scheduled || open|| || || | ||
|- | |- | ||
− | | instance.create_ip || open || antal || || | + | | instance.create_ip || open || antal || || renamed to add_fixed_ip to be more precise |
|- | |- | ||
− | | instance.delete_ip || open || || || | + | | instance.delete_ip || open || || || rename it to remove_fixed_ip |
|- | |- | ||
| instance.evacuate || open || || || | | instance.evacuate || open || || || |
Revision as of 15:36, 27 June 2016
Contents
Goal
Transform every legacy notification to the new versioned notification framework.
How to do it
- Check the notification devref that describes the new framework: http://docs.openstack.org/developer/nova/notifications.html
- Check the existing new versioned notification example: https://review.openstack.org/#/c/245678/
- Check the example transformation patch: https://review.openstack.org/#/c/313654/
- Select a task for the below table and add your IRC handle to table. (Please take only one at a time)
- Propose a transformation patch based on the examples.
- Make sure that you create a new sample file under doc/notificaiton_samples/
- Make sure that you add a notification sample test under nova/tests/functional/notification_sample_test/
- If you got stuck you can ask questions from rlrossit and gibi on IRC or join the weekly notification subteam meeting https://wiki.openstack.org/wiki/Meetings/NovaNotification
Tasks
Please do not start working on a new task until the currently opened tasks are close to merge to avoid overloading the cores
The easy ones that uses the same payload as instance.delete:
event type | status | taken by | review | comments |
---|---|---|---|---|
instance.delete | subteam review | gibi | https://review.openstack.org/#/c/313654 | This shall be the base of for the other instance.<action> transformation |
instance.shutdown | open | siva_krishnan | https://review.openstack.org/#/c/329214 | |
instance.scheduled | open | |||
instance.create_ip | open | antal | renamed to add_fixed_ip to be more precise | |
instance.delete_ip | open | rename it to remove_fixed_ip | ||
instance.evacuate | open | |||
instance.migration | open | |||
instance.pause | open | sneti | https://review.openstack.org/#/c/329141/ | |
instance.unpause | open | sneti | ||
instance.power_on | open | zhs | https://review.openstack.org/#/c/329746/ | |
instance.power_off | open | xenogear | https://review.openstack.org/#/c/330761/ | |
instance.reboot | open | macsz | ||
instance.reboot.error | open | |||
instance.shelve | open | vancsics | https://review.openstack.org/#/c/332696/ | |
instance.shelve_offload | open | |||
instance.unshelve | open | |||
instance.snapshot | open | syjulian | ||
instance.soft_delete | open | |||
instance.suspend | open | pumaranikar | https://review.openstack.org/#/c/329089 | |
instance.resume | open | siva_krishnan | ||
instance.restore | open | zhs | https://review.openstack.org/#/c/331972/ | |
instance.trigger_crash_dump | open | |||
instance.unrescue | open | |||
instance.create | open | Some of the instance.create.<phase> notifications has extra payload | ||
instance.rebuild | open | pumaranikar | ||
instance.rebuild.scheduled | open | we might need to change the event_type | ||
instance.resize | open | aunnam | https://review.openstack.org/#/c/329255/ | |
instance.resize.error | open | |||
instance.resize.prep | open | we might need to change the event_type | ||
instance.finish_resize | open | we might want to change the even_type | ||
instance.resize.confirm | open | |||
instance.resize.revert | open | |||
instance.live.migration.abort | open | we might need to change the even_type to make it consistent | ||
instance.live_migration.pre | open | we might want to change the event_type | ||
instance.live_migration.rollback.dest | open | we might want to change the event_type | ||
instance.live_migration._rollback | open | we might want to change the event_type | ||
instance.live_migration._post | open | we might want to change the even_type | ||
instance.live_migration.post.dest | open | we might want to change the event_type |
The complex instance.<action> notifications that needs payload extension.
event type | status | taken by | review | comments |
---|---|---|---|---|
instance.update | needs patch | gibi | https://review.openstack.org/#/c/325923/ | This shall be the example for creating instance.<action> notification with extended InstancePayload |
instance.exists | open | |||
instance.rescue | open | |||
instance.volume.attach | open |
The rest:
event type | status | taken by | review | comments |
---|---|---|---|---|
compute.exception | subtream review | laszloh | https://review.openstack.org/#/c/310700 | |
aggregate.addhost | open | |||
aggregate.create | open | |||
aggregate.delete | open | |||
aggregate.removehost | open | |||
aggregate.updatemetadata | open | |||
aggregate.updateprop | open | |||
api.fault | open | |||
libvirt.error | open | |||
compute_task.build_instances | open | |||
compute_task.migrate_server | open | |||
compute_task.rebuild_server | open | |||
HostAPI.power_action | open | |||
HostAPI.set_enabled | open | |||
HostAPI.set_maintenance | open | |||
keypair.create | spec exists | h-eguchi | spec: https://review.openstack.org/#/c/300942 | |
keypair.delete | spec exists | h-eguchi | spec: https://review.openstack.org/#/c/300942 | |
keypair.import | spec exists | h-eguchi | spec: https://review.openstack.org/#/c/300942 | |
network.floating_ip.allocate | open | |||
network.floating_ip.associate | open | |||
network.floating_ip.deallocate | open | |||
network.floating_ip.disassociate | open | |||
scheduler.select_destinations | open | |||
servergroup.addmember | open | |||
servergroup.create | open | |||
servergroup.delete | open | |||
volume.usage | open | |||
metrics.update | open | sudipto |
Follow up tasks
Mostly for after N-2
- add a reno note about the transformed notifications
- rlrossit will remove the vm_state - InstanceState value duplication
- improve doc generation, include a sample link in the doc that is valid also before the sample adding patch is merged. (look at the api-ref doc work for ideas)
* separate the notification object unit test from the nova object version test. Done
- solve security issue in wrap_exception notification see the comments in https://review.openstack.org/#/c/310700/19/nova/compute/utils.py and https://review.openstack.org/#/c/310700/19/nova/exception_wrapper.py