Jump to: navigation, search

Difference between revisions of "Swift/PriorityReviews"

Line 3: Line 3:
 
= Review Priorities =
 
= Review Priorities =
  
In preparation for Swift 2.10.0, which is to be included in the OpenStack Newton release, please prioritize these reviews:
 
  
== Should land ==
+
== Critical Bug ==
  
<strike>https://review.openstack.org/#/c/162243/
+
EC missing durable can prevent reconstruction -- https://bugs.launchpad.net/swift/+bug/1624088
* object creation more atomic in linux</strike>
+
* https://review.openstack.org/#/c/376630/
  
<strike>https://review.openstack.org/#/c/348495/
+
== Other patches to review ==
* critical bug affecting prod for HPE</strike>
 
  
<strike>https://review.openstack.org/#/c/215276/
+
*https://review.openstack.org/#/c/323950/
* object server return non-durable data
+
** refactor locale tests
* needs upgrade testing: run up proxy and object servers with and without the patch, and vice versa, then run func tests to check there is no upgrade issue
+
** small patch
** then write down what you saw (good or bad) in gerrit!</strike>
 
  
<strike>https://review.openstack.org/#/c/346865/
+
*https://review.openstack.org/#/c/210099/
* Delete old tombstones</strike>
+
** process-level concurrency from container sync
 +
** why hasn't it landed yet?
  
----
+
*https://review.openstack.org/#/c/347538/
 +
** store SLO Etag and size in sysmeta
  
== Would be nice to land ==
+
*https://review.openstack.org/#/c/219165/
 +
** global EC (it's a big patch)
 +
** kota needs it
  
https://review.openstack.org/#/c/210099/
+
*https://review.openstack.org/#/c/232162/
* process-level concurrency from container sync
+
** symlink
* why hasn't it landed yet?
 
  
<strike>https://review.openstack.org/#/c/357559/</strike>
+
*https://review.openstack.org/#/c/337297/
* include metadata on POST responses
+
** increase ring part power
  
https://review.openstack.org/#/c/347538/
+
*https://review.openstack.org/#/c/356715/
* store SLO Etag and size in sysmeta
+
** json account ACLs with keystoneauth
  
https://review.openstack.org/#/c/219165/
+
*https://review.openstack.org/#/c/337960/
* global EC
+
** send correct SLO Etag for container update
* kota really wants it in
+
** We need to discuss more about the client-visible impact (https://bugs.launchpad.net/swift/+bug/1618573)
* big change for last minute?
 
  
https://review.openstack.org/#/c/232162/
+
*https://review.openstack.org/#/c/336323/
* symlink
+
** test xattrs
* unlikely to land due to size vs deadline
+
** needs gate change to pass (notmyname is working on that)
 +
** will significantly impact dev environments
  
https://review.openstack.org/#/c/337297/
+
*https://review.openstack.org/#/c/218490/
* increase ring part power
+
** referesh memcache settings
* no current reviews
+
** not critical, but nice to have
* unlikely to land do to size vs deadline
 
 
 
https://review.openstack.org/#/c/323950/
 
* refactor locale tests
 
* small patch
 
 
 
----
 
 
 
== Very very unlikely to land, but look at these after all of the above have landed ==
 
 
 
https://review.openstack.org/#/c/356715/
 
* json account ACLs with keystoneauth
 
* unlikely to land
 
 
 
https://review.openstack.org/#/c/337960/
 
* send correct SLO Etag for container update
 
* I want to defer this to discuss more about the client-visible impact
 
 
 
https://review.openstack.org/#/c/336323/
 
* test xattrs
 
* needs gate change to pass
 
* won't land
 
 
 
https://review.openstack.org/#/c/218490/
 
* referesh memcache settings
 
* not critical, but nice to have
 
 
 
https://review.openstack.org/#/c/355958/
 
* eliminate .durable files
 
* large patch, but the vast majority is tests
 
  
  

Revision as of 23:08, 1 November 2016

Swift Review Dashboard: https://goo.gl/eqeGwE

Review Priorities

Critical Bug

EC missing durable can prevent reconstruction -- https://bugs.launchpad.net/swift/+bug/1624088

Other patches to review


Bug Triage Links

swiftclient bugs: https://goo.gl/uO4b7l <-- bugs that are marked "New" and need triage

swift bugs: https://goo.gl/LMiiDc <-- bugs that are marked "New" and need triage


Swift Review Dashboard

https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Fswift+OR+project%3Aopenstack%2Fpython%2Dswiftclient+OR+project%3Aopenstack%2Fswift%2Dpython%2Dagent+OR+project%3Aopenstack%2Fswift%2Dbench+OR+project%3Aopenstack%2Fswift%2Dspecs%29+status%3Aopen+NOT+label%3AWorkflow%3C%3D%2D1+NOT+label%3ACode%2DReview%3C%3D%2D2+is%3Amergeable&title=Swift+Review+Dashboard&Starred+%28by+PTL+or+myself%29=%28starredby%3Anotmyname+OR+is%3Astarred%29+AND+status%3Aopen&Small+things=delta%3A%3C%3D25+limit%3A10+%28NOT+label%3ACode%2DReview%2D1%2Cswift%2Dcore+OR+%28label%3ACode%2DReview%2D1%2Cswiftclient%2Dcore+AND+project%3Aopenstack%2Fpython%2Dswiftclient%29%29&Needs+Final+Approval+%28to+land+on+master%29=NOT+label%3AWorkflow%3E%3D1+NOT+label%3AWorkflow%3C%3D%2D1+NOT+owner%3Aself+label%3ACode%2DReview%3E%3D2+%28NOT+label%3ACode%2DReview%2D1%2Cswift%2Dcore+OR+%28label%3ACode%2DReview%2D1%2Cswiftclient%2Dcore+AND+project%3Aopenstack%2Fpython%2Dswiftclient%29%29+NOT+project%3Aopenstack%2Fswift%2Dspecs+branch%3Amaster&Open+Backport+Proposals=NOT+project%3Aopenstack%2Fswift%2Dspecs+branch%3A%5Estable%2F.%2A+status%3Aopen&Feature+Branches=NOT+project%3Aopenstack%2Fswift%2Dspecs+branch%3A%5Efeature%2F.%2A+status%3Aopen&Recently+Proposed+to+master=NOT+label%3AWorkflow%3E%3D1+%28NOT+label%3ACode%2DReview%2D1%2Cswift%2Dcore+OR+%28label%3ACode%2DReview%2D1%2Cswiftclient%2Dcore+AND+project%3Aopenstack%2Fpython%2Dswiftclient%29%29+label%3AVerified%3E%3D1%2Cjenkins+NOT+label%3ACode%2DReview%3E%3D2+NOT+project%3Aopenstack%2Fswift%2Dspecs+%2Dage%3A1week+branch%3Amaster&Older+open+patches=NOT+label%3AWorkflow%3E%3D1+NOT+label%3ACode%2DReview%3C%3D2+age%3A1week+NOT+project%3Aopenstack%2Fswift%2Dspecs+%28NOT+label%3ACode%2DReview%2D1%2Cswift%2Dcore+OR+%28label%3ACode%2DReview%2D1%2Cswiftclient%2Dcore+AND+project%3Aopenstack%2Fpython%2Dswiftclient%29%29&Swift+Specs=project%3Aopenstack%2Fswift%2Dspecs+NOT+label%3ACode%2DReview%3C%3D%2D2


https://goo.gl/mtEv1C




Swift Project Overview Dashboard

https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Fswift+OR+project%3Aopenstack%2Fpython%2Dswiftclient+OR+project%3Aopenstack%2Fswift%2Dbench+OR+project%3Aopenstack%2Fswift%2Dspecs%29+status%3Aopen+is%3Amergeable&title=Swift+Project+Dashboard&Starred+Patches+%28by+core%29=%28%28starredby%3Atorgomatic+OR+starredby%3Acschwede+OR+starredby%3A%22alistair.coles%40hpe.com%22+OR+starredby%3A%22darrell%40swiftstack.com%22+OR+starredby%3A%22david.goetz%40rackspace.com%22+OR+starredby%3A%22greglange%40gmail.com%22+OR+starredby%3A%22matt%40oliver.net.au%22+OR+starredby%3A%22mike%40weirdlooking.com%22+OR+starredby%3A%22zaitcev%40kotori.zaitcev.us%22+OR+starredby%3A%22paul.e.luse%40intel.com%22+OR+starredby%3Anotmyname+OR+starredby%3A%22tsuyuzaki.kota%40lab.ntt.co.jp%22+OR+starredby%3A%22thiago%40redhat.com%22%29+OR+%28%28starredby%3A%22joel.wright%40sohonet.com%22+OR+starredby%3A%22tim.burke%40gmail.com%22%29+AND+project%3Aopenstack%2Fpython%2Dswiftclient%29%29+AND+status%3Aopen&Needs+Final+Approval+%28to+land+on+master%29=NOT+label%3AWorkflow%3E%3D1+NOT+label%3AWorkflow%3C%3D%2D1+NOT+owner%3Aself+label%3ACode%2DReview%3E%3D2+%28NOT+label%3ACode%2DReview%2D1%2Cswift%2Dcore+OR+%28label%3ACode%2DReview%2D1%2Cswiftclient%2Dcore+AND+project%3Aopenstack%2Fpython%2Dswiftclient%29%29+NOT+project%3Aopenstack%2Fswift%2Dspecs+branch%3Amaster&In+the+gate+queue=label%3AWorkflow%3E%3D1+NOT+label%3ACode%2DReview%3C%3D%2D2&Needs+Reverify=label%3AVerified%3C%3D%2D1%2Cjenkins+NOT+project%3Aopenstack%2Fswift%2Dspecs+branch%3Amaster+NOT+label%3ACode%2DReview%3C%3D%2D1+NOT+label%3AWorkflow%3C%3D%2D1+NOT+label%3ACode%2DReview%3C%3D%2D2&Possible+abandoned+changes=status%3Aopen+age%3A4week+%28label%3AVerified%3C%3D%2D1%2Cjenkins+OR+label%3ACode%2DReview%3C%3D%2D1%29+NOT+label%3AWorkflow%3C%3D%2D1

https://goo.gl/DV5vkD