|
|
| (31 intermediate revisions by 16 users not shown) |
| Line 1: |
Line 1: |
| − | __NOTOC__
| + | #REDIRECT [http://docs.openstack.org/infra/manual/developers.html#peer-review OpenStack Infra Manual] |
| − | This page includes a list of things that reviewers should keep in mind when reviewing patches to [[OpenStack]] projects. There are some items that are common across all projects and others that are specific to a project.
| |
| | | | |
| − | = Common Review Checklist =
| + | The content of this page is now hosted on [http://docs.openstack.org/infra/manual/developers.html#peer-review OpenStack Infra Manual] |
| − | | |
| − | 1. The code should comply with everything in [https://github.com/openstack/openstack-common/blob/master/HACKING.rst HACKING].
| |
| − | | |
| − | 2. When adding a new file:
| |
| − | * '''a)''' If it's not installed by setup.py, but should be included in the tarball, be sure to add it to `MANIFEST.in`.
| |
| − | | |
| − | = Nova Review Checklist =
| |
| − | | |
| − | 1. When adding a new file:
| |
| − | # Check common checklist items for adding new files.
| |
| − | # If you are adding a new script in the `bin/` directory, add it to `setup.py`.
| |
Latest revision as of 01:45, 4 December 2014
#REDIRECT OpenStack Infra Manual
The content of this page is now hosted on OpenStack Infra Manual
