|
|
| (28 intermediate revisions by 13 users not shown) |
| Line 1: |
Line 1: |
| | + | #REDIRECT [http://docs.openstack.org/infra/manual/developers.html#peer-review OpenStack Infra Manual] |
| | | | |
| − | This page includes a list of things that reviewers should keep in mind when reviewing patches to [[OpenStack]] projects. There are some items that are common across all projects and others that are specific to a project.
| + | The content of this page is now hosted on [http://docs.openstack.org/infra/manual/developers.html#peer-review OpenStack Infra Manual] |
| − | | |
| − | = Common Review Checklist =
| |
| − | | |
| − | 1. The code should comply with everything in [https://github.com/openstack/oslo-incubator/blob/master/HACKING.rst HACKING].
| |
| − | | |
| − | 2. When adding a new file:
| |
| − | * '''a)''' If it's not installed by setup.py, but should be included in the tarball, be sure to add it to `MANIFEST.in`.
| |
| − | | |
| − | 3. A single commit should be as small as is practicable while maintaining atomic functionality. If a commit message includes "and do this other thing", it should probably be split up.
| |
| − | | |
| − | = Nova Review Checklist =
| |
| − | | |
| − | 1. When adding a new file:
| |
| − | # Check common checklist items for adding new files.
| |
| − | # If you are adding a new script in the `bin/` directory, add it to `setup.py`. | |
| − | | |
| − | = Notes for Non-Core Developers =
| |
| − | | |
| − | * When you are reviewing, you may notice a review that has several +1's from other reviewers, passes the functional tests, etc. but the code still has not been merged. As only core developers can approve code for merging, you can help things along by getting a core developer's attention and letting them know there is a review with lots of positive reviews and needs final approval.
| |
Latest revision as of 01:45, 4 December 2014
#REDIRECT OpenStack Infra Manual
The content of this page is now hosted on OpenStack Infra Manual
