Difference between revisions of "ReviewChecklist"
m (Text replace - "__NOTOC__" to "") |
|||
| Line 4: | Line 4: | ||
= Common Review Checklist = | = Common Review Checklist = | ||
| − | 1. The code should comply with everything in [https://github.com/openstack/ | + | 1. The code should comply with everything in [https://github.com/openstack/oslo-incubator/blob/master/HACKING.rst HACKING]. |
2. When adding a new file: | 2. When adding a new file: | ||
| Line 14: | Line 14: | ||
# Check common checklist items for adding new files. | # Check common checklist items for adding new files. | ||
# If you are adding a new script in the `bin/` directory, add it to `setup.py`. | # If you are adding a new script in the `bin/` directory, add it to `setup.py`. | ||
| + | |||
| + | = Notes for Non-Core Developers = | ||
| + | |||
| + | * When you are reviewing, you may notice a review that has several +1's from other reviewers, passes the functional tests, etc. but the code still has not been merged. As only core developers can approve code for merging, you can help things along by getting a core developer's attention and letting them know there is a review with lots of positive reviews and needs final approval. | ||
Revision as of 22:04, 2 May 2013
This page includes a list of things that reviewers should keep in mind when reviewing patches to OpenStack projects. There are some items that are common across all projects and others that are specific to a project.
Common Review Checklist
1. The code should comply with everything in HACKING.
2. When adding a new file:
- a) If it's not installed by setup.py, but should be included in the tarball, be sure to add it to `MANIFEST.in`.
Nova Review Checklist
1. When adding a new file:
- Check common checklist items for adding new files.
- If you are adding a new script in the `bin/` directory, add it to `setup.py`.
Notes for Non-Core Developers
- When you are reviewing, you may notice a review that has several +1's from other reviewers, passes the functional tests, etc. but the code still has not been merged. As only core developers can approve code for merging, you can help things along by getting a core developer's attention and letting them know there is a review with lots of positive reviews and needs final approval.
