Jump to: navigation, search

Difference between revisions of "ReviewChecklist"

 
m (Text replace - "__NOTOC__" to "")
Line 1: Line 1:
__NOTOC__
+
 
 
This page includes a list of things that reviewers should keep in mind when reviewing patches to [[OpenStack]] projects. There are some items that are common across all projects and others that are specific to a project.
 
This page includes a list of things that reviewers should keep in mind when reviewing patches to [[OpenStack]] projects. There are some items that are common across all projects and others that are specific to a project.
  

Revision as of 23:30, 17 February 2013

This page includes a list of things that reviewers should keep in mind when reviewing patches to OpenStack projects. There are some items that are common across all projects and others that are specific to a project.

Common Review Checklist

1. The code should comply with everything in HACKING.

2. When adding a new file:

  • a) If it's not installed by setup.py, but should be included in the tarball, be sure to add it to `MANIFEST.in`.

Nova Review Checklist

1. When adding a new file:

  1. Check common checklist items for adding new files.
  2. If you are adding a new script in the `bin/` directory, add it to `setup.py`.