Difference between revisions of "Puppet/Coding style"
< Puppet
(→Documentation) |
(→Asking for review) |
||
| Line 22: | Line 22: | ||
== Asking for review == | == Asking for review == | ||
| + | Different ways to get reviewsː | ||
| + | * Go on IRC #puppet-openstack (freenode) and gently ask for reviews. If you need to discuss about already reviewed code, you can ping the reviewers. | ||
| + | * Add your patch on the [[Meetings/PuppetOpenStack#Agenda | Puppet OpenStack meeting Agenda]] (in Open Discussion section). | ||
| + | * Use [[Puppet/Mailing_lists|Mailing list]]. | ||
Revision as of 03:13, 15 September 2015
Before coding
- Read this page
- Make sure that what you're going to code is not already work in progress
- Make sure you're familiar with Puppet Syntax, Lint, Rspec, and Beaker
- If you want to create a new module, read Puppet/New_module
Best practices
Testing
Your code needs to be tested. Puppet OpenStack CI will verify for you, but if you want to save time, you better to run tests locally before sending a patchː
Documentation
- Validate all parameters are documented. They are required and lint will check it.
- If possible, keep examples/*.pp updated, they are very useful for our users.
- Comment your code when needed (temporary workarounds, TODO, etc).
Asking for review
Different ways to get reviewsː
- Go on IRC #puppet-openstack (freenode) and gently ask for reviews. If you need to discuss about already reviewed code, you can ping the reviewers.
- Add your patch on the Puppet OpenStack meeting Agenda (in Open Discussion section).
- Use Mailing list.
