Difference between revisions of "Poppy/Developer - Review Guidelines"
< Poppy
Line 1: | Line 1: | ||
+ | ===== Poppy Code Review Guidelines | ||
+ | ===== | ||
Below are 'some' of the things to watch out for during code reviews. Please update this list as you come across new ones. | Below are 'some' of the things to watch out for during code reviews. Please update this list as you come across new ones. | ||
Revision as of 20:19, 10 November 2014
===== Poppy Code Review Guidelines
=====
Below are 'some' of the things to watch out for during code reviews. Please update this list as you come across new ones.
- Docstrings are updated if needed
- Commit messages reflect bps, bugs if applicable (https://wiki.openstack.org/wiki/Gerrit_Workflow#Committing_Changes)
- No trailing whitespaces :)
- Keep in mind the design priniciples