Jump to: navigation, search


< Nova
Revision as of 08:29, 13 July 2016 by Gibi (talk | contribs) (Follow up tasks)


Transform every legacy notification to the new versioned notification framework.

How to do it


Further transformation work needs to wait unit master is open for Ocata

The easy ones that uses the same payload as instance.delete:

event type status taken by review comments
instance.delete merged gibi https://review.openstack.org/#/c/313654 This shall be the base of for the other instance.<action> transformation
instance.shutdown move to Ocata siva_krishnan https://review.openstack.org/#/c/329214
instance.scheduled open
instance.create_ip move to Ocata antal https://review.openstack.org/#/c/332876/ renamed to add_fixed_ip to be more precise
instance.delete_ip open rename it to remove_fixed_ip
instance.evacuate open
instance.migration open
instance.pause merged sneti https://review.openstack.org/#/c/329141/
instance.unpause open sneti
instance.power_on merged zhs https://review.openstack.org/#/c/329746/
instance.power_off move to Ocata xenogear https://review.openstack.org/#/c/330761/
instance.reboot mova to Ocata macsz https://review.openstack.org/#/c/330224/
instance.reboot.error open
instance.shelve merged vancsics https://review.openstack.org/#/c/332696/
instance.shelve_offload open
instance.unshelve open
instance.snapshot move to Ocata syjulian https://review.openstack.org/#/c/330128/
instance.soft_delete open
instance.suspend merged pumaranikar https://review.openstack.org/#/c/329089
instance.resume open siva_krishnan
instance.restore merged zhs https://review.openstack.org/#/c/331972/
instance.trigger_crash_dump open
instance.unrescue open
instance.create open Some of the instance.create.<phase> notifications has extra payload
instance.rebuild open pumaranikar
instance.rebuild.scheduled open we might need to change the event_type
instance.resize merged aunnam https://review.openstack.org/#/c/329255/
instance.resize.error open
instance.resize.prep open we might need to change the event_type
instance.finish_resize open we might want to change the even_type
instance.resize.confirm open
instance.resize.revert open
instance.live.migration.abort open we might need to change the even_type to make it consistent
instance.live_migration.pre open we might want to change the event_type
instance.live_migration.rollback.dest open we might want to change the event_type
instance.live_migration._rollback open we might want to change the event_type
instance.live_migration._post open we might want to change the even_type
instance.live_migration.post.dest open we might want to change the event_type

The complex instance.<action> notifications that needs payload extension.

event type status taken by review comments
instance.update merged gibi https://review.openstack.org/#/c/325923/ This shall be the example for creating instance.<action> notification with extended InstancePayload
instance.exists open
instance.rescue open
instance.volume.attach open

The rest:

event type status taken by review comments
compute.exception merged laszloh https://review.openstack.org/#/c/310700
aggregate.addhost open
aggregate.create open
aggregate.delete open
aggregate.removehost open
aggregate.updatemetadata open
aggregate.updateprop open
api.fault open
libvirt.error open
compute_task.build_instances open
compute_task.migrate_server open
compute_task.rebuild_server open
HostAPI.power_action open
HostAPI.set_enabled open
HostAPI.set_maintenance open
keypair.create spec exists h-eguchi spec: https://review.openstack.org/#/c/300942
keypair.delete spec exists h-eguchi spec: https://review.openstack.org/#/c/300942
keypair.import spec exists h-eguchi spec: https://review.openstack.org/#/c/300942
network.floating_ip.allocate open
network.floating_ip.associate open
network.floating_ip.deallocate open
network.floating_ip.disassociate open
scheduler.select_destinations open
servergroup.addmember open
servergroup.create open
servergroup.delete open
volume.usage open
metrics.update open sudipto

Follow up tasks

Mostly for after N-2

* separate the notification object unit test from the nova object version test. Done

* replace set_override with self.flags in https://review.openstack.org/#/c/332696/5/nova/tests/functional/notification_sample_tests/test_instance.py

In Ocata:

  • after the json schema patch is merged in ovo and a new ovo lib version is released we can add a tool to nova generate the json schemas for the versioned notifications.