Jump to: navigation, search

Difference between revisions of "Nova/VersionedNotificationTransformation"

(→‎Tasks)
 
(91 intermediate revisions by 17 users not shown)
Line 1: Line 1:
 +
= This work has been completed =
 +
 +
The information below is kept here for historical reasons
 +
 
== Goal ==
 
== Goal ==
 
Transform every legacy notification to the new versioned notification framework.
 
Transform every legacy notification to the new versioned notification framework.
Line 4: Line 8:
 
== How to do it ==
 
== How to do it ==
 
* Check the notification devref that describes the new framework:  http://docs.openstack.org/developer/nova/notifications.html
 
* Check the notification devref that describes the new framework:  http://docs.openstack.org/developer/nova/notifications.html
−
* Check the existing new versioned notification example: https://review.openstack.org/#/c/245678/
+
* Check the existing transformation patches  that are merged: http://burndown.peermore.com/nova-notification/
−
* Check the example transformation patch: https://review.openstack.org/#/c/313654/
+
* Select a transformation from the table on http://burndown.peermore.com/nova-notification/ You can take a patch with status TODO or you can check if a patch that is INPROGRESS needs help.  
−
* Select a task for the below table and add your IRC handle to table. (Please take only one at a time)
 
 
* Propose a transformation patch based on the examples.
 
* Propose a transformation patch based on the examples.
−
* If you got stuck you can ask questions from rlrossit and gibi on IRC or join the weekly notification subteam meeting https://wiki.openstack.org/wiki/Meetings/NovaNotification  
+
** Make sure that you create a new sample file under doc/notificaiton_samples/
 +
** Make sure that you add a notification sample test under nova/tests/functional/notification_sample_test/
 +
* If you got stuck you can ask questions from gibi on IRC or join the weekly notification subteam meeting https://wiki.openstack.org/wiki/Meetings/NovaNotification
  
 
== Tasks ==
 
== Tasks ==
  
−
The easy ones that uses the same payload as instance.delete:
+
Please use the https://review.openstack.org/#/q/topic:bp/versioned-notification-transformation-rocky topic for the transformation commits
 +
 
 +
 
 +
<big> [http://burndown.peermore.com/nova-notification/ The burndown chart is updated hourly from gerrit. ] </big>
 +
You can see what to transform and what to review there.
  
−
{| class="wikitable"
 
−
|-
 
−
! event type !! status !! taken by !! review !! comments
 
−
|-
 
−
| instance.delete || subteam review || gibi || https://review.openstack.org/#/c/313654  || This shall be the base of for the other instance.<action> transformation
 
−
|-
 
−
| instance.shutdown || open ||  ||  ||
 
−
|-
 
−
| instance.scheduled || open||  ||  ||
 
−
|-
 
−
| instance.create_ip || open ||  ||  ||
 
−
|-
 
−
| instance.delete_ip || open ||  ||  ||
 
−
|-
 
−
| instance.evacuate || open ||  ||  ||
 
−
|-
 
−
| instance.migration || open ||  ||  ||
 
−
|-
 
−
| instance.pause || open ||  ||  ||
 
−
|-
 
−
| instance.unpause || open ||  ||  ||
 
−
|-
 
−
| instance.power_on || open ||  ||  ||
 
−
|-
 
−
| instance.power_off || open ||  ||  ||
 
−
|-
 
−
| instance.reboot || open ||  ||  ||
 
−
|-
 
−
| instance.shelve || open ||  ||  ||
 
−
|-
 
−
| instance.shelve_offload || open ||  ||  ||
 
−
|-
 
−
| instance.unshelve || open ||  ||  ||
 
−
|-
 
−
| instance.snapshot || open ||  ||  ||
 
−
|-
 
−
| instance.soft_delete || open ||  ||  ||
 
−
|-
 
−
| instance.suspend || open ||  ||  ||
 
−
|-
 
−
| instance.resume || open ||  ||  ||
 
−
|-
 
−
| instance.restore || open ||  ||  ||
 
−
|-
 
−
| instance.trigger_crash_dump || open ||  ||  ||
 
−
|-
 
−
| instance.unrescue || open ||  ||  ||
 
−
|-
 
−
| instance.create || open ||  ||  || Some of the instance.create.<phase> notifications has extra payload
 
−
|-
 
−
| instance.rebuild || open ||  ||  ||
 
−
|-
 
−
| instance.rebuild.scheduled || open ||  ||  || we might need to change the event_type
 
−
|-
 
−
| instance.resize || open ||  ||  ||
 
−
|-
 
−
| instance.resize.prep || open ||  ||  || we might need to change the event_type
 
−
|-
 
−
| instance.finish_resize || open ||  ||  || we might want to change the even_type
 
−
|-
 
−
| instance.resize.confirm || open ||  ||  ||
 
−
|-
 
−
| instance.resize.revert || open ||  ||  ||
 
−
|-
 
−
| instance.live.migration.abort || open ||  ||  || we might need to change the even_type to make it consistent
 
−
|-
 
−
| instance.live_migration.pre || open ||  ||  || we might want to change the event_type
 
−
|-
 
−
| instance.live_migration.rollback.dest || open  ||  ||  || we might want to change the event_type
 
−
|-
 
−
| instance.live_migration._rollback || open ||  ||  || we might want to change the event_type
 
−
|-
 
−
| instance.live_migration._post || open ||  ||  || we might want to change the even_type
 
−
|-
 
−
| instance.live_migration.post.dest || open ||  ||  || we might want to change the event_type
 
−
|}
 
  
−
The complex instance.<action> notifications that needs payload extension.
+
There are three types of transformations:
−
{| class="wikitable"
+
* category: instance-payload: The easy ones that uses the same payload as instance.delete
−
|-
+
* category: extended-instance-payload: The complex instance.<action> notifications that needs payload extension.
−
! event type !! status !! taken by !! review !! comments
+
* category: specific-payload: The rest that needs specific payload
−
|-
 
−
| instance.update || needs patch || gibi ||  ||
 
−
|-
 
−
| instance.exists || open ||  ||  ||
 
−
|-
 
−
| instance.rescue || open ||  ||  ||
 
−
|-
 
−
| instance.volume.attach || open ||  ||  ||
 
−
|}
 
  
−
The rest:
 
  
−
{| class="wikitable"
+
If something doesn't show up on the burndown then please ping gibi on IRC.
−
|-
 
−
! event type !! status !! taken by !! review !! comments
 
−
|-
 
−
| compute.exception || subtream review || laszloh ||  https://review.openstack.org/#/c/310700 ||
 
−
|-
 
−
| aggregate.addhost || open ||  ||  ||
 
−
|-
 
−
| aggregate.create || open ||  ||  ||
 
−
|-
 
−
| aggregate.delete || open ||  ||  ||
 
−
|-
 
−
| aggregate.removehost || open ||  ||  ||
 
−
|-
 
−
| aggregate.updatemetadata || open ||  ||  ||
 
−
|-
 
−
| aggregate.updateprop || open ||  ||  ||
 
−
|-
 
−
| api.fault || open ||  ||  ||
 
−
|-
 
−
| libvirt.error || open ||  ||  ||
 
−
|-
 
−
| compute_task.build_instances || open ||  ||  ||
 
−
|-
 
−
| compute_task.migrate_server || open ||  ||  ||
 
−
|-
 
−
| compute_task.rebuild_server || open ||  ||  ||
 
−
|-
 
−
| HostAPI.power_action || open ||  ||  ||
 
−
|-
 
−
| HostAPI.set_enabled || open ||  ||  ||
 
−
|-
 
−
| HostAPI.set_maintenance || open ||  ||  ||
 
−
|-
 
−
| keypair.create || spec exists ||  h-eguchi ||  spec: https://review.openstack.org/#/c/300942 ||
 
−
|-
 
−
| keypair.delete || spec exists || h-eguchi ||  spec: https://review.openstack.org/#/c/300942 ||
 
−
|-
 
−
| keypair.import || spec exists ||  h-eguchi ||  spec: https://review.openstack.org/#/c/300942 ||
 
−
|-
 
−
| network.floating_ip.allocate || open ||  ||  ||
 
−
|-
 
−
| network.floating_ip.associate || open ||  ||  ||
 
−
|-
 
−
| network.floating_ip.deallocate || open ||  ||  ||
 
−
|-
 
−
| network.floating_ip.disassociate || open ||  ||  ||
 
−
|-
 
−
| scheduler.select_destinations || open ||  ||  ||
 
−
|-
 
−
| servergroup.addmember || open ||  ||  ||
 
−
|-
 
−
| servergroup.create || open ||  ||  ||
 
−
|-
 
−
| servergroup.delete || open ||  ||  ||
 
−
|-
 
−
| volume.usage || open ||  ||  ||
 
−
|}
 

Latest revision as of 09:21, 10 December 2018

This work has been completed

The information below is kept here for historical reasons

Goal

Transform every legacy notification to the new versioned notification framework.

How to do it

Tasks

Please use the https://review.openstack.org/#/q/topic:bp/versioned-notification-transformation-rocky topic for the transformation commits


The burndown chart is updated hourly from gerrit. You can see what to transform and what to review there.


There are three types of transformations:

  • category: instance-payload: The easy ones that uses the same payload as instance.delete
  • category: extended-instance-payload: The complex instance.<action> notifications that needs payload extension.
  • category: specific-payload: The rest that needs specific payload


If something doesn't show up on the burndown then please ping gibi on IRC.

Retrieved from "https://wiki.openstack.org/w/index.php?title=Nova/VersionedNotificationTransformation&oldid=167172"