Difference between revisions of "Nova/VersionedNotificationTransformation"

Revision as of 12:54, 2 June 2016

Goal

Transform every legacy notification to the new versioned notification framework.

How to do it

Check the notification devref that describes the new framework: http://docs.openstack.org/developer/nova/notifications.html
Check the existing new versioned notification example: https://review.openstack.org/#/c/245678/
Check the example transformation patch: https://review.openstack.org/#/c/313654/
Select a task for the below table and add your IRC handle to table. (Please take only one at a time)
Propose a transformation patch based on the examples.
If you got stuck you can ask questions from rlrossit and gibi on IRC or join the weekly notification subteam meeting https://wiki.openstack.org/wiki/Meetings/NovaNotification

Tasks

The easy ones that uses the same payload as instance.delete:

event type	status	taken by	review	comments
instance.delete	subteam review	gibi	https://review.openstack.org/#/c/313654	This shall be the base of for the other instance.<action> transformation
instance.create	open			Some of the instance.create.<phase> notifications has extra payload
instance.shutdown	open
instance.scheduled	open
instance.create_ip	open
instance.evacuate	open
instance.migration	open
instance.pause	open
instance.power_off	open
instance.reboot	open
instance.shelve	open
instance.snapshot	open
instance.soft_delete	open
instance.suspend	open
instance.trigger_crash_dump	open
instance.unrescue	open
instance.delete_ip	open
instance.live.migration.abort	open			we might need to change the even_type to make it consistent
instance.power_on	open
instance.rebuild.scheduled	open			we might need to change the event_type
instance.resize.prep	open			we might need to change the event_type
instance.resize	open
instance.restore	open
instance.resume	open
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example

The complex instance.<action> notifications:

event type	status	taken by	review	comments
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example

The rest:

event type	status	taken by	review	comments
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example
Example	Example	Example	Example	Example

@@ Line 20: / Line 20: @@
 | instance.delete || subteam review || gibi || https://review.openstack.org/#/c/313654  || This shall be the base of for the other instance.<action> transformation
 |-
-| Example || Example || Example || Example || Example
+| instance.create || open ||  ||  || Some of the instance.create.<phase> notifications has extra payload
 |-
-| Example || Example || Example || Example || Example
+| instance.shutdown || open ||  ||  ||
 |-
-| Example || Example || Example || Example || Example
+| instance.scheduled || open||  ||  ||
 |-
-| Example || Example || Example || Example || Example
+| instance.create_ip || open ||  ||  ||
+|-
+| instance.evacuate || open ||  ||  ||
+|-
+| instance.migration || open ||  ||  ||
+|-
+| instance.pause || open ||  ||  ||
+|-
+| instance.power_off || open ||  ||  ||
+|-
+| instance.reboot || open ||  ||  ||
+|-
+| instance.shelve || open ||  ||  ||
+|-
+| instance.snapshot || open ||  ||  ||
+|-
+| instance.soft_delete || open ||  ||  ||
+|-
+| instance.suspend || open ||  ||  ||
+|-
+| instance.trigger_crash_dump || open ||  ||  ||
+|-
+| instance.unrescue || open ||  ||  ||
+|-
+| instance.delete_ip || open ||  ||  ||
+|-
+| instance.live.migration.abort || open ||  ||  || we might need to change the even_type to make it consistent
+|-
+| instance.power_on || open ||  ||  ||
+|-
+| instance.rebuild.scheduled || open ||  ||  || we might need to change the event_type
+|-
+| instance.resize.prep || open ||  ||  || we might need to change the event_type
+|-
+| instance.resize || open ||  ||  ||
+|-
+| instance.restore || open ||  ||  ||
+|-
+| instance.resume || open ||  ||  ||
 |-
 | Example || Example || Example || Example || Example