Jump to: navigation, search

Difference between revisions of "NeutronReviews"

m (Mestery moved page NeutronCodeReviews to NeutronReviews)
(No difference)

Revision as of 19:29, 22 May 2014

Code reviews are a critical component of all OpenStack projects. Neutron accepts patches from many diverse people with diverse backgrounds, employers, and experience levels. Code reviews provide a way to enforce a level of consistency across the project, and also allow for the careful on boarding of contributions from new contributors.

Neutron Code Review Practices

Neutron follows the [code review guidelines as set forth for all OpenStack projects. It is expected that all reviewers are following the guidelines set forth in that page.

Assigned Reviewers

Anyone can assign a reviewer for a code reviewer using gerrit. In addition, anyone can review any patch in gerrit. However, for items of critical or high priority, the Neutron core team will assign 2 core reviewers to these items. These items are deemed as critically important to the community in most cases, and assuring they have as much review coverage as they do development coverage makes sense for the project. It is at the core teams discretion to assign core reviewers to medium or lower priority items.

Tracking Review Statistics

Stackalytics provides some nice interfaces to track review statistics. The links are provided below. These statistics are used to track not only core reviewer statistics, but also to track review statistics for potential future core members.