Jump to: navigation, search

Difference between revisions of "Neutron/ReviewDays"

(9 intermediate revisions by 5 users not shown)
Line 1: Line 1:
 
__NOTOC__
 
__NOTOC__
−
We are thinking about having an assigned reviewer for each day.
+
----
 +
As we enter the Grizzly release cycle, we are also back to normal with review days. All quantum core devs are therefore invited to sign up in the list below.
  
 +
----
 
Review duty rotates between [https://launchpad.net/~quantum-core/+members#active every (human) member of quantum-core]. If you are the assigned reviewer, it's your responsibility to: /* start */
 
Review duty rotates between [https://launchpad.net/~quantum-core/+members#active every (human) member of quantum-core]. If you are the assigned reviewer, it's your responsibility to: /* start */
 
* Set blueprint proposals to "Approved" if appropriate, or request more information.
 
* Set blueprint proposals to "Approved" if appropriate, or request more information.
 
* Review patches.
 
* Review patches.
−
* Assign domain experts to patches withouth a review. In this case the domain expert might be or might not be a core dev. In the latter case a core dev should probably be selected as well for the branch.
+
* Assign domain experts to patches withouth a review. In this case the domain expert might be or might not be a core dev. In the latter case a core dev should probably be selected as well for the branch. NOTE: Following input for the design summit we should be identifying domains and respective experts for Quantum.
 
* Respond to queries from contributors concerning pending reviews or blueprint approvals.
 
* Respond to queries from contributors concerning pending reviews or blueprint approvals.
 
* Pester assigned reviewers to review branches.
 
* Pester assigned reviewers to review branches.
 +
* Assign new bug report to domain experts, or triage then if you happen to be an expert for the domain the bug report refers to.
 +
* Answer questions on Launchpad or on the Openstack-dev mailing list if they are pertinent to your area of expertise (Actually core devs are invited to do so not just on their review day!)
  
 
/* end */
 
/* end */
Line 21: Line 25:
  
 
/* end */
 
/* end */
−
 
−
''Folsom RC Special Review Guidelines''
 
−
 
−
* only spend core review cycles on items that are assigned to Folsom RC1: https://launchpad.net/quantum/+milestone/folsom-rc1
 
−
* sign up for two review days a week.  The goal is two have two core devs active on each day to improve round-trip time on reviews.  Reviews should be smaller during this period.
 
−
* on your review day, also triage any new quantum bugs to identify any that may need to apply to RC1.  Focus on triaging all bugs in 'New' state, moving them to 'confirmed', 'invalid', or 'incomplete', and assigning them a priority.  See [[BugTriage]] for more details.  If anything is unclear discuss it with PTL.
 
−
* send update to to the core team at the start of your review day (describing your plans), and at the end of your review day (describing what you accomplished). Please use subject "Quantum Folsom RC-1" and the launchpad link for contacting quantum-core:https://launchpad.net/~quantum-core/+contactuser
 
  
 
See [[People]] for mappings between real names and IRC handles.
 
See [[People]] for mappings between real names and IRC handles.
Line 36: Line 33:
 
| EMEA  
 
| EMEA  
 
|-
 
|-
−
| Tuesday August 28th
+
| Monday October 22nd
−
| Mark [[McClain]]
+
| 
 +
| 
 +
|-
 +
| Tuesday October 23rd
 +
|
 
| Gary Kotton  
 
| Gary Kotton  
 
|-
 
|-
−
|<style="text-align:center" |2>|Wednesday August 29th
+
| Wednesday October 24th
−
|<style="text-align:center" |2>|Edgar Magana
+
| Edgar Magana
−
| Maru Newby
+
|
 
|-
 
|-
 +
| Thursday October 25th
 +
| 
 +
| Gary Kotton
 
|-
 
|-
−
|<style="text-align:center" |2>|Thursday August 30th
+
| Friday October 26th
−
|<style="text-align:center" |2>|Dan Wendlandt
+
|
 +
|
 +
|-
 +
| Saturday October 27th
 +
|
 
| Salvatore Orlando  
 
| Salvatore Orlando  
 
|-
 
|-
 +
| Sunday October 28th
 +
| 
 +
| Gary Kotton
 +
|-
 +
| Monday October 29th
 +
| 
 +
| 
 +
|-
 +
| Tuesday October 30th
 +
| 
 +
| Gary Kotton
 +
|-
 +
| Wednesday October 31st
 +
| Edgar Magana
 +
| 
 
|-
 
|-
−
| Friday August 31st
+
| Thursday November 1st
−
| Sumit Naiksatam
+
| 
 +
| Gary Kotton
 +
|-
 +
| Friday November 2nd
 +
|
 
| Salvatore Orlando  
 
| Salvatore Orlando  
 
|-
 
|-
−
| Saturday September 1st
+
| Saturday November 3rd
−
| Mark [[McClain]]
+
|
 
|   
 
|   
 
|-
 
|-
−
| Sunday September 2nd
+
| Sunday November 4th
−
| Dan Wendlandt
+
|
 
| Gary Kotton  
 
| Gary Kotton  
 
|-
 
|-
−
| Monday September 3rd
+
| Monday November 5th
 +
| 
 +
| 
 +
|-
 +
| Tuesday November 6th
 
|   
 
|   
 
| Gary Kotton  
 
| Gary Kotton  
 
|-
 
|-
−
| Tuesday September 4th
+
| Wednesday November 7th
−
| Mark [[McClain]]
+
| Edgar Magana
−
| Salvatore Orlando
+
|
 
|-
 
|-
−
| Wednesday September 5th
+
| Thursday November 8th
−
| Edgar Magana
+
|
 
| Gary Kotton  
 
| Gary Kotton  
 
|-
 
|-
−
| Thursday September 6th
+
| Friday November 9th
−
| Dan Wendlandt
+
|
 
| Salvatore Orlando  
 
| Salvatore Orlando  
 
|-
 
|-
−
| Friday September 7th
+
| Saturday November 10th
−
| Sumit Naiksatam
 
−
| Maru Newby
 
−
|-
 
−
| Saturday September 8th
 
 
|   
 
|   
 
|   
 
|   
 
|-
 
|-
−
| Sunday September 9th
+
| Sunday November 11th
−
| Dan Wendlandt
+
|
 
| Gary Kotton  
 
| Gary Kotton  
 
|}
 
|}

Revision as of 17:45, 22 October 2012

As we enter the Grizzly release cycle, we are also back to normal with review days. All quantum core devs are therefore invited to sign up in the list below.

Review duty rotates between every (human) member of quantum-core. If you are the assigned reviewer, it's your responsibility to: /* start */

  • Set blueprint proposals to "Approved" if appropriate, or request more information.
  • Review patches.
  • Assign domain experts to patches withouth a review. In this case the domain expert might be or might not be a core dev. In the latter case a core dev should probably be selected as well for the branch. NOTE: Following input for the design summit we should be identifying domains and respective experts for Quantum.
  • Respond to queries from contributors concerning pending reviews or blueprint approvals.
  • Pester assigned reviewers to review branches.
  • Assign new bug report to domain experts, or triage then if you happen to be an expert for the domain the bug report refers to.
  • Answer questions on Launchpad or on the Openstack-dev mailing list if they are pertinent to your area of expertise (Actually core devs are invited to do so not just on their review day!)

/* end */

Active reviews for trunk: https://review.openstack.org/#q,status:open+project:openstack/quantum,n,z

Every human member of quantum-core should be part of this rotation. As we have core developers in several we will try to leverage this as much as possible. For this reason, the table below has 3 columns corresponding to 3 different time "areas": Americas, EMEA, and APAC.

Approximately a core reviewer would be available in the following hours: /* start */

  • APAC: 1AM GMT - 9AM GMT
  • EMEA: 9AM GMT - 5PM GMT
  • Americas: 5PM GMT - 1AM GMT

/* end */

See People for mappings between real names and IRC handles.

Day Americas EMEA
Monday October 22nd
Tuesday October 23rd Gary Kotton
Wednesday October 24th Edgar Magana
Thursday October 25th Gary Kotton
Friday October 26th
Saturday October 27th Salvatore Orlando
Sunday October 28th Gary Kotton
Monday October 29th
Tuesday October 30th Gary Kotton
Wednesday October 31st Edgar Magana
Thursday November 1st Gary Kotton
Friday November 2nd Salvatore Orlando
Saturday November 3rd
Sunday November 4th Gary Kotton
Monday November 5th
Tuesday November 6th Gary Kotton
Wednesday November 7th Edgar Magana
Thursday November 8th Gary Kotton
Friday November 9th Salvatore Orlando
Saturday November 10th
Sunday November 11th Gary Kotton
Retrieved from "https://wiki.openstack.org/w/index.php?title=Neutron/ReviewDays&oldid=14844"