Difference between revisions of "Neutron/ReviewDays"

Revision as of 16:02, 28 August 2012

We are thinking about having an assigned reviewer for each day.

Review duty rotates between every (human) member of quantum-core. If you are the assigned reviewer, it's your responsibility to: /* start */

Set blueprint proposals to "Approved" if appropriate, or request more information.
Review patches.
Assign domain experts to patches withouth a review. In this case the domain expert might be or might not be a core dev. In the latter case a core dev should probably be selected as well for the branch.
Respond to queries from contributors concerning pending reviews or blueprint approvals.
Pester assigned reviewers to review branches.

/* end */

Active reviews for trunk: https://review.openstack.org/#q,status:open+project:openstack/quantum,n,z

Every human member of quantum-core should be part of this rotation. As we have core developers in several we will try to leverage this as much as possible. For this reason, the table below has 3 columns corresponding to 3 different time "areas": Americas, EMEA, and APAC.

Approximately a core reviewer would be available in the following hours: /* start */

APAC: 1AM GMT - 9AM GMT
EMEA: 9AM GMT - 5PM GMT
Americas: 5PM GMT - 1AM GMT

/* end */

Folsom RC Special Review Guidelines

only spend core review cycles on items that are assigned to Folsom RC1: https://launchpad.net/quantum/+milestone/folsom-rc1
sign up for two review days a week. The goal is two have two core devs active on each day to improve round-trip time on reviews. Reviews should be smaller during this period.
on your review day, also triage any new quantum bugs to identify any that may need to apply to RC1. Focus on triaging all bugs in 'New' state, moving them to 'confirmed', 'invalid', or 'incomplete', and assigning them a priority. See BugTriage for more details. If anything is unclear discuss it with PTL.
send update to to the core team at the start of your review day (describing your plans), and at the end of your review day (describing what you accomplished). Please use subject "Quantum Folsom RC-1" and the launchpad link for contacting quantum-core:https://launchpad.net/~quantum-core/+contactuser

See People for mappings between real names and IRC handles.

Day	Americas	EMEA
Tuesday August 28th	Mark McClain	Gary Kotton
2>\|Wednesday August 29th	2>\|Edgar Magana	Maru Newby
2>\|Thursday August 30th	2>\|Dan Wendlandt	Salvatore Orlando
Friday August 31st	Sumit Naiksatam	Salvatore Orlando
Saturday September 1st	Mark McClain
Sunday September 2nd	Dan Wendlandt	Gary Kotton
Monday September 3rd		Gary Kotton
Tuesday September 4th	Mark McClain	Salvatore Orlando
Wednesday September 5th	Edgar Magana	Gary Kotton
Thursday September 6th	Dan Wendlandt	Salvatore Orlando
Friday September 7th	Sumit Naiksatam	Maru Newby
Saturday September 8th
Sunday September 9th	Dan Wendlandt	Gary Kotton

@@ Line 22: / Line 22: @@
 /* end */
-It would be great if we could fill every column for each day, but having just one reviewer on duty in a given time area 4 days out of 5 would probably be an acceptable result. The idea is to start this scheme on Monday June 18th, and Update this schedule every 2 weeks,  in order to accomodate as much as possible for holydays or other things.
+''Folsom RC Special Review Guidelines''
+* only spend core review cycles on items that are assigned to Folsom RC1: https://launchpad.net/quantum/+milestone/folsom-rc1
+* sign up for two review days a week.  The goal is two have two core devs active on each day to improve round-trip time on reviews.  Reviews should be smaller during this period.
+* on your review day, also triage any new quantum bugs to identify any that may need to apply to RC1.  Focus on triaging all bugs in 'New' state, moving them to 'confirmed', 'invalid', or 'incomplete', and assigning them a priority.  See [[BugTriage]] for more details.  If anything is unclear discuss it with PTL.
+* send update to to the core team at the start of your review day (describing your plans), and at the end of your review day (describing what you accomplished). Please use subject "Quantum Folsom RC-1" and the launchpad link for contacting quantum-core:https://launchpad.net/~quantum-core/+contactuser
 See [[People]] for mappings between real names and IRC handles.
@@ Line 31: / Line 36: @@
 | EMEA
 |-
-| Monday July 30th
+| Tuesday August 28th
-| TBA
+| Mark [[McClain]]
-| TBA
-|-
-| Tuesday July 31st
-| TBA
-| Salvatore Orlando
-|-
-| Wednesday August 1st
-| Bob Kukura
-| Salvatore Orlando
-|-
-| Thursday August 2nd
-| Sumit Naiksatam
-| TBA
-|-
-| Friday August 3rd
-| Dan Wendlandt
-| Gary Kotton
-|-
-| Saturday August 4th
-| TBA
-| TBA
-|-
-| Sunday August 5th
-| Somik Behera
-| Gary Kotton
-|-
-| Monday August 6th
-| Edgar Magana
 | Gary Kotton
 |-
-| Tuesday August 7th
+|<style="text-align:center" |2>|Wednesday August 29th
-| Somik Behera
+|<style="text-align:center" |2>|Edgar Magana
-| TBA
+| Maru Newby
-|-
-| Wednesday August 8th
-| Bob Kukura
-| TBA
 |-
-| Thursday August 9th
-| Sumit Naiksatam / Aaron Rosen
-| Salvatore Orlando Gary Kotton
 |-
-| Friday August 10th
+|<style="text-align:center" |2>|Thursday August 30th
-| Dan Wendlandt
+|<style="text-align:center" |2>|Dan Wendlandt
 | Salvatore Orlando
 |-
-| Saturday August 11th
-| TBA
-| TBA
 |-
-| Sunday August 12th
+| Friday August 31st
-| TBA
+| Sumit Naiksatam
-| Gary Kotton
-|-
-| Monday August 13th
-| Edgar Magana
 | Salvatore Orlando
 |-
-| Tuesday August 14th
+| Saturday September 1st
-| Bob Kukura/Aaron Rosen
+| Mark [[McClain]]
-| Salvatore Orlando
+|
 |-
-| Wednesday August 15th
+| Sunday September 2nd
 | Dan Wendlandt
 | Gary Kotton
 |-
-| Thursday August 16th
+| Monday September 3rd
-| Aaron Rosen
+|
 | Gary Kotton
 |-
-| Friday August 17th
+| Tuesday September 4th
-| Sumit Naiksatam
+| Mark [[McClain]]
-| TBA
+| Salvatore Orlando
 |-
-| Saturday August 18th
+| Wednesday September 5th
-| TBA
+| Edgar Magana
-| TBA
-|-
-| Sunday August 19th
-| TBA
 | Gary Kotton
-|}
-For Folsom-3, we have many LARGE reviews.  Please sign up for the set of reviews that you will continue to revisit until they are merged for F-3.
-{| border="1" cellpadding="2" cellspacing="0"
 |-
-| Review Topic''' '''
+| Thursday September 6th
-| Review Link
+| Dan Wendlandt
-| Core Dev #1
+| Salvatore Orlando
 |-
-| Provider Networks
+| Friday September 7th
-| https://review.openstack.org/#/c/10938/
+| Sumit Naiksatam
-| danwent
+| Maru Newby
 |-
-| DB models for dns/routes
+| Saturday September 8th
-| https://review.openstack.org/#/c/10791/
-| sorlando
-|-
-| RPC support for LB Plugin
-| https://review.openstack.org/#/c/9591/
-| danwent
-|-
-| RPC support for OVS Plugin
-| https://review.openstack.org/#/c/10879/
-| sorlando
-|-
-| RPC support for DHCP
-| https://review.openstack.org/#/c/10997/
 |
-|-
-| quotas API
-| https://review.openstack.org/#/c/10484/
-| danwent
-|-
-| Public/shared Networks
-| https://review.openstack.org/#/c/9845/
 |
 |-
-| L3 + Floating IPs
+| Sunday September 9th
-| https://review.openstack.org/#/c/10993/
+| Dan Wendlandt
-| Aaron Rosen
+| Gary Kotton
-|-
-| L3 + Floating IP CLI/client
-| https://review.openstack.org/#/c/10994/
-|
-|-
-| Per-network DHCP enable
-| https://review.openstack.org/#/c/10320/
-| sorlando
-|-
-| bulk API operations
-| https://review.openstack.org/#/c/10732/
-|
-|-
-| v1 code removal
-| https://review.openstack.org/#/c/10998/
-|
-|-
-| NEC plugin
-| https://review.openstack.org/#/c/10664/
-|
-|-
-| ISC DHCP
-| https://review.openstack.org/#/c/10443/
-|
 |}
-Note: if you click through to a review and already seen that two other core devs are active on it, please sign up for other reviews so we can maximize coverage.
-Note: there are many smaller reviews that we're not listing here. It does not mean that they are less important, just that they require less coordination regarding reviewer cycles.  Also, if a review was for a plugin with an obvious set of core maintainers who would review (Nicira, Cisco), I omitted it.