Difference between revisions of "Neutron/ReviewDays"
< Neutron
| Line 25: | Line 25: | ||
* only spend core review cycles on items that are assigned to Folsom RC1: https://launchpad.net/quantum/+milestone/folsom-rc1 | * only spend core review cycles on items that are assigned to Folsom RC1: https://launchpad.net/quantum/+milestone/folsom-rc1 | ||
| − | * sign up for two review days a week. The goal is two have two core devs active on each day to improve round-trip time on reviews. Reviews should be smaller during this period. | + | * sign up for two review days a week. The goal is two have two core devs active on each day to improve round-trip time on reviews. Reviews should be smaller during this period. |
| − | * on your review day, also triage any new quantum bugs to identify any that may need to apply to RC1. Focus on triaging all bugs in 'New' state, moving them to 'confirmed', 'invalid', or 'incomplete', and assigning them a priority. See [[BugTriage]] for more details. If anything is unclear discuss it with PTL. | + | * on your review day, also triage any new quantum bugs to identify any that may need to apply to RC1. Focus on triaging all bugs in 'New' state, moving them to 'confirmed', 'invalid', or 'incomplete', and assigning them a priority. See [[BugTriage]] for more details. If anything is unclear discuss it with PTL. |
| − | * send update to to the core team at the start of your review day (describing your plans), and at the end of your review day (describing what you accomplished). Please use subject "Quantum Folsom RC-1" and the launchpad link for contacting quantum-core:https://launchpad.net/~quantum-core/+contactuser | + | * send update to to the core team at the start of your review day (describing your plans), and at the end of your review day (describing what you accomplished). Please use subject "Quantum Folsom RC-1" and the launchpad link for contacting quantum-core:https://launchpad.net/~quantum-core/+contactuser |
See [[People]] for mappings between real names and IRC handles. | See [[People]] for mappings between real names and IRC handles. | ||
| Line 37: | Line 37: | ||
|- | |- | ||
| Tuesday August 28th | | Tuesday August 28th | ||
| − | | | + | | Mark [[McClain]] |
| − | | | + | | Gary Kotton |
|- | |- | ||
| − | | | + | |<style="text-align:center" |2>|Wednesday August 29th |
| − | | | + | |<style="text-align:center" |2>|Edgar Magana |
| − | | | + | | Maru Newby |
|- | |- | ||
|- | |- | ||
| − | | | + | |<style="text-align:center" |2>|Thursday August 30th |
| − | | | + | |<style="text-align:center" |2>|Dan Wendlandt |
| − | | | + | | Salvatore Orlando |
|- | |- | ||
|- | |- | ||
| Friday August 31st | | Friday August 31st | ||
| − | | | + | | Sumit Naiksatam |
| − | | | + | | Salvatore Orlando |
|- | |- | ||
| Saturday September 1st | | Saturday September 1st | ||
| − | | | + | | Mark [[McClain]] |
| | | | ||
|- | |- | ||
| Sunday September 2nd | | Sunday September 2nd | ||
| − | | | + | | Dan Wendlandt |
| − | | | + | | Gary Kotton |
|- | |- | ||
| Monday September 3rd | | Monday September 3rd | ||
| | | | ||
| − | | | + | | Gary Kotton |
|- | |- | ||
| Tuesday September 4th | | Tuesday September 4th | ||
| − | | | + | | Mark [[McClain]] |
| − | | | + | | Salvatore Orlando |
|- | |- | ||
| Wednesday September 5th | | Wednesday September 5th | ||
| − | | | + | | Edgar Magana |
| − | | | + | | Gary Kotton |
|- | |- | ||
| Thursday September 6th | | Thursday September 6th | ||
| − | | | + | | Dan Wendlandt |
| − | | | + | | Salvatore Orlando |
|- | |- | ||
| Friday September 7th | | Friday September 7th | ||
| − | | | + | | Sumit Naiksatam |
| − | | | + | | Maru Newby |
|- | |- | ||
| Saturday September 8th | | Saturday September 8th | ||
| Line 86: | Line 86: | ||
| | | | ||
|- | |- | ||
| − | | Sunday September 9th | + | | Sunday September 9th |
| − | | | + | | Dan Wendlandt |
| − | | | + | | Gary Kotton |
| + | |} | ||
Revision as of 16:02, 28 August 2012
We are thinking about having an assigned reviewer for each day.
Review duty rotates between every (human) member of quantum-core. If you are the assigned reviewer, it's your responsibility to: /* start */
- Set blueprint proposals to "Approved" if appropriate, or request more information.
- Review patches.
- Assign domain experts to patches withouth a review. In this case the domain expert might be or might not be a core dev. In the latter case a core dev should probably be selected as well for the branch.
- Respond to queries from contributors concerning pending reviews or blueprint approvals.
- Pester assigned reviewers to review branches.
/* end */
Active reviews for trunk: https://review.openstack.org/#q,status:open+project:openstack/quantum,n,z
Every human member of quantum-core should be part of this rotation. As we have core developers in several we will try to leverage this as much as possible. For this reason, the table below has 3 columns corresponding to 3 different time "areas": Americas, EMEA, and APAC.
Approximately a core reviewer would be available in the following hours: /* start */
- APAC: 1AM GMT - 9AM GMT
- EMEA: 9AM GMT - 5PM GMT
- Americas: 5PM GMT - 1AM GMT
/* end */
Folsom RC Special Review Guidelines
- only spend core review cycles on items that are assigned to Folsom RC1: https://launchpad.net/quantum/+milestone/folsom-rc1
- sign up for two review days a week. The goal is two have two core devs active on each day to improve round-trip time on reviews. Reviews should be smaller during this period.
- on your review day, also triage any new quantum bugs to identify any that may need to apply to RC1. Focus on triaging all bugs in 'New' state, moving them to 'confirmed', 'invalid', or 'incomplete', and assigning them a priority. See BugTriage for more details. If anything is unclear discuss it with PTL.
- send update to to the core team at the start of your review day (describing your plans), and at the end of your review day (describing what you accomplished). Please use subject "Quantum Folsom RC-1" and the launchpad link for contacting quantum-core:https://launchpad.net/~quantum-core/+contactuser
See People for mappings between real names and IRC handles.
| Day | Americas | EMEA |
| Tuesday August 28th | Mark McClain | Gary Kotton |
| 2>|Wednesday August 29th | 2>|Edgar Magana | Maru Newby |
| 2>|Thursday August 30th | 2>|Dan Wendlandt | Salvatore Orlando |
| Friday August 31st | Sumit Naiksatam | Salvatore Orlando |
| Saturday September 1st | Mark McClain | |
| Sunday September 2nd | Dan Wendlandt | Gary Kotton |
| Monday September 3rd | Gary Kotton | |
| Tuesday September 4th | Mark McClain | Salvatore Orlando |
| Wednesday September 5th | Edgar Magana | Gary Kotton |
| Thursday September 6th | Dan Wendlandt | Salvatore Orlando |
| Friday September 7th | Sumit Naiksatam | Maru Newby |
| Saturday September 8th | ||
| Sunday September 9th | Dan Wendlandt | Gary Kotton |
