Jump to: navigation, search

Difference between revisions of "Neutron/ReviewDays"

Line 22: Line 22:
 
/* end */
 
/* end */
  
It would be great if we could fill every column for each day, but having just one reviewer on duty in a given time area 4 days out of 5 would probably be an acceptable result. The idea is to start this scheme on Monday June 18th, and Update this schedule every 2 weeks, in order to accomodate as much as possible for holydays or other things.
+
''Folsom RC Special Review Guidelines''
 +
 
 +
* only spend core review cycles on items that are assigned to Folsom RC1: https://launchpad.net/quantum/+milestone/folsom-rc1
 +
* on your review day, also triage any new quantum bugs to identify any that may need to apply to RC1.  Focus on triaging all bugs in 'New' state, moving them to 'confirmed', 'invalid', or 'incomplete', and assigning them a priority. See [[BugTriage]] for more details.  If anything is unclear discuss it with PTL.  
  
 
See [[People]] for mappings between real names and IRC handles.
 
See [[People]] for mappings between real names and IRC handles.

Revision as of 15:42, 28 August 2012

We are thinking about having an assigned reviewer for each day.

Review duty rotates between every (human) member of quantum-core. If you are the assigned reviewer, it's your responsibility to: /* start */

  • Set blueprint proposals to "Approved" if appropriate, or request more information.
  • Review patches.
  • Assign domain experts to patches withouth a review. In this case the domain expert might be or might not be a core dev. In the latter case a core dev should probably be selected as well for the branch.
  • Respond to queries from contributors concerning pending reviews or blueprint approvals.
  • Pester assigned reviewers to review branches.

/* end */

Active reviews for trunk: https://review.openstack.org/#q,status:open+project:openstack/quantum,n,z

Every human member of quantum-core should be part of this rotation. As we have core developers in several we will try to leverage this as much as possible. For this reason, the table below has 3 columns corresponding to 3 different time "areas": Americas, EMEA, and APAC.

Approximately a core reviewer would be available in the following hours: /* start */

  • APAC: 1AM GMT - 9AM GMT
  • EMEA: 9AM GMT - 5PM GMT
  • Americas: 5PM GMT - 1AM GMT

/* end */

Folsom RC Special Review Guidelines

  • only spend core review cycles on items that are assigned to Folsom RC1: https://launchpad.net/quantum/+milestone/folsom-rc1
  • on your review day, also triage any new quantum bugs to identify any that may need to apply to RC1. Focus on triaging all bugs in 'New' state, moving them to 'confirmed', 'invalid', or 'incomplete', and assigning them a priority. See BugTriage for more details. If anything is unclear discuss it with PTL.

See People for mappings between real names and IRC handles.

Day Americas EMEA
Tuesday August 28th Mark McClain Gary Kotton
Wednesday August 29th Maru Newby
Thursday August 30th Dan Wendlandt Salvatore Orlando
Friday August 31st Sumit Naiksatam Salvatore Orlando
Saturday September 1st Mark McClain
Sunday September 2nd Gary Kotton
Monday September 3rd Gary Kotton
Tuesday September 4th Mark McClain Salvatore Orlando
Wednesday September 5th Gary Kotton
Thursday September 6th Dan Wendlandt Salvatore Orlando
Friday September 7th Sumit Naiksatam Maru Newby
Saturday September 8th
Sunday September 9th Gary Kotton