Difference between revisions of "Neutron/ReviewDays"
Line 122: | Line 122: | ||
| Review Link | | Review Link | ||
| Core Dev #1 | | Core Dev #1 | ||
+ | | Core Dev #2 | ||
|- | |- | ||
| Provider Networks | | Provider Networks | ||
| https://review.openstack.org/#/c/10938/ | | https://review.openstack.org/#/c/10938/ | ||
| danwent | | danwent | ||
+ | | sorlando | ||
|- | |- | ||
| DB models for dns/routes | | DB models for dns/routes | ||
| https://review.openstack.org/#/c/10791/ | | https://review.openstack.org/#/c/10791/ | ||
| sorlando | | sorlando | ||
+ | | Aaron Rosen | ||
|- | |- | ||
| RPC support for LB Plugin | | RPC support for LB Plugin | ||
| https://review.openstack.org/#/c/9591/ | | https://review.openstack.org/#/c/9591/ | ||
| sorlando | | sorlando | ||
+ | | danwent | ||
+ | | | ||
|- | |- | ||
| RPC support for OVS Plugin | | RPC support for OVS Plugin | ||
| https://review.openstack.org/#/c/10879/ | | https://review.openstack.org/#/c/10879/ | ||
| sorlando | | sorlando | ||
+ | | Aaron Rosen | ||
+ | | | ||
|- | |- | ||
| RPC support for DHCP | | RPC support for DHCP | ||
| https://review.openstack.org/#/c/10997/ | | https://review.openstack.org/#/c/10997/ | ||
| Gary Kotton | | Gary Kotton | ||
+ | | Sumit Naiksatam | ||
+ | | | ||
|- | |- | ||
| quotas API | | quotas API | ||
| https://review.openstack.org/#/c/10484/ | | https://review.openstack.org/#/c/10484/ | ||
| danwent | | danwent | ||
+ | | Sumit Naiksatam | ||
+ | | | ||
|- | |- | ||
| Public/shared Networks | | Public/shared Networks | ||
| https://review.openstack.org/#/c/9845/ | | https://review.openstack.org/#/c/9845/ | ||
| Gary Kotton | | Gary Kotton | ||
+ | | Sumit Naiksatam | ||
+ | | | ||
|- | |- | ||
| L3 + Floating IPs | | L3 + Floating IPs | ||
| https://review.openstack.org/#/c/10993/ | | https://review.openstack.org/#/c/10993/ | ||
| Aaron Rosen | | Aaron Rosen | ||
+ | | Maru Newby | ||
+ | | | ||
|- | |- | ||
| L3 + Floating IP CLI/client | | L3 + Floating IP CLI/client | ||
| https://review.openstack.org/#/c/10994/ | | https://review.openstack.org/#/c/10994/ | ||
| sorlando | | sorlando | ||
+ | | Maru Newby | ||
+ | | | ||
|- | |- | ||
| v2 devstack exercise scripts | | v2 devstack exercise scripts | ||
| https://review.openstack.org/#/c/10828/ | | https://review.openstack.org/#/c/10828/ | ||
| danwent | | danwent | ||
+ | | | ||
+ | | | ||
|- | |- | ||
| <s>Per-network DHCP enable</s> | | <s>Per-network DHCP enable</s> | ||
| <s>https://review.openstack.org/#/c/10320/</s> | | <s>https://review.openstack.org/#/c/10320/</s> | ||
| <s>sorlando</s> | | <s>sorlando</s> | ||
+ | | <s>Edgar Magana</s> | ||
+ | | | ||
|- | |- | ||
| bulk API operations | | bulk API operations | ||
| https://review.openstack.org/#/c/10732/ | | https://review.openstack.org/#/c/10732/ | ||
+ | | | ||
+ | | | ||
| | | | ||
|- | |- | ||
Line 174: | Line 197: | ||
| https://review.openstack.org/#/c/10998/ | | https://review.openstack.org/#/c/10998/ | ||
| Sumit Naiksatam | | Sumit Naiksatam | ||
+ | | Edgar Magana | ||
+ | | | ||
|- | |- | ||
| NEC plugin | | NEC plugin | ||
| https://review.openstack.org/#/c/10664/ | | https://review.openstack.org/#/c/10664/ | ||
| Gary Kotton | | Gary Kotton | ||
+ | | | ||
+ | | | ||
|- | |- | ||
| ISC DHCP | | ISC DHCP | ||
| https://review.openstack.org/#/c/10443/ | | https://review.openstack.org/#/c/10443/ | ||
| Gary Kotton | | Gary Kotton | ||
+ | | | ||
+ | | | ||
|- | |- | ||
| Meta plugin | | Meta plugin | ||
| https://review.openstack.org/#/c/10181/ | | https://review.openstack.org/#/c/10181/ | ||
| Gary Kotton | | Gary Kotton | ||
+ | | Edgar Magana | ||
+ | | | ||
|} | |} | ||
Revision as of 16:14, 10 August 2012
We are thinking about having an assigned reviewer for each day.
Review duty rotates between every (human) member of quantum-core. If you are the assigned reviewer, it's your responsibility to: /* start */
- Set blueprint proposals to "Approved" if appropriate, or request more information.
- Review patches.
- Assign domain experts to patches withouth a review. In this case the domain expert might be or might not be a core dev. In the latter case a core dev should probably be selected as well for the branch.
- Respond to queries from contributors concerning pending reviews or blueprint approvals.
- Pester assigned reviewers to review branches.
/* end */
Active reviews for trunk: https://review.openstack.org/#q,status:open+project:openstack/quantum,n,z
Every human member of quantum-core should be part of this rotation. As we have core developers in several we will try to leverage this as much as possible. For this reason, the table below has 3 columns corresponding to 3 different time "areas": Americas, EMEA, and APAC.
Approximately a core reviewer would be available in the following hours: /* start */
- APAC: 1AM GMT - 9AM GMT
- EMEA: 9AM GMT - 5PM GMT
- Americas: 5PM GMT - 1AM GMT
/* end */
It would be great if we could fill every column for each day, but having just one reviewer on duty in a given time area 4 days out of 5 would probably be an acceptable result. The idea is to start this scheme on Monday June 18th, and Update this schedule every 2 weeks, in order to accomodate as much as possible for holydays or other things.
See People for mappings between real names and IRC handles.
Day | Americas | EMEA |
Monday July 30th | TBA | TBA |
Tuesday July 31st | TBA | Salvatore Orlando |
Wednesday August 1st | Bob Kukura | Salvatore Orlando |
Thursday August 2nd | Sumit Naiksatam | TBA |
Friday August 3rd | Dan Wendlandt | Gary Kotton |
Saturday August 4th | TBA | TBA |
Sunday August 5th | Somik Behera | Gary Kotton |
Monday August 6th | Edgar Magana | Gary Kotton |
Tuesday August 7th | Somik Behera | TBA |
Wednesday August 8th | Bob Kukura | TBA |
Thursday August 9th | Sumit Naiksatam / Aaron Rosen | Salvatore Orlando Gary Kotton |
Friday August 10th | Dan Wendlandt | Salvatore Orlando |
Saturday August 11th | TBA | TBA |
Sunday August 12th | TBA | Gary Kotton |
Monday August 13th | Edgar Magana | Salvatore Orlando |
Tuesday August 14th | Bob Kukura/Aaron Rosen | Salvatore Orlando |
Wednesday August 15th | Dan Wendlandt | Gary Kotton |
Thursday August 16th | Aaron Rosen | Gary Kotton |
Friday August 17th | Sumit Naiksatam | TBA |
Saturday August 18th | TBA | TBA |
Sunday August 19th | TBA | Gary Kotton |
For Folsom-3, we have many LARGE reviews. Please sign up for the set of reviews that you will continue to revisit until they are merged for F-3.
Review Topic | Review Link | Core Dev #1 | Core Dev #2 | |
Provider Networks | https://review.openstack.org/#/c/10938/ | danwent | sorlando | |
DB models for dns/routes | https://review.openstack.org/#/c/10791/ | sorlando | Aaron Rosen | |
RPC support for LB Plugin | https://review.openstack.org/#/c/9591/ | sorlando | danwent | |
RPC support for OVS Plugin | https://review.openstack.org/#/c/10879/ | sorlando | Aaron Rosen | |
RPC support for DHCP | https://review.openstack.org/#/c/10997/ | Gary Kotton | Sumit Naiksatam | |
quotas API | https://review.openstack.org/#/c/10484/ | danwent | Sumit Naiksatam | |
Public/shared Networks | https://review.openstack.org/#/c/9845/ | Gary Kotton | Sumit Naiksatam | |
L3 + Floating IPs | https://review.openstack.org/#/c/10993/ | Aaron Rosen | Maru Newby | |
L3 + Floating IP CLI/client | https://review.openstack.org/#/c/10994/ | sorlando | Maru Newby | |
v2 devstack exercise scripts | https://review.openstack.org/#/c/10828/ | danwent | ||
|
|
|
|
|
bulk API operations | https://review.openstack.org/#/c/10732/ | |||
v1 code removal | https://review.openstack.org/#/c/10998/ | Sumit Naiksatam | Edgar Magana | |
NEC plugin | https://review.openstack.org/#/c/10664/ | Gary Kotton | ||
ISC DHCP | https://review.openstack.org/#/c/10443/ | Gary Kotton | ||
Meta plugin | https://review.openstack.org/#/c/10181/ | Gary Kotton | Edgar Magana |
Note: if you click through to a review and already seen that two other core devs are active on it, please sign up for other reviews so we can maximize coverage.
Note: there are many smaller reviews that we're not listing here. It does not mean that they are less important, just that they require less coordination regarding reviewer cycles. Also, if a review was for a plugin with an obvious set of core maintainers who would review (Nicira, Cisco), I omitted it.