Jump to: navigation, search

Difference between revisions of "Network/Meetings"

(On Demand Agenda)
Line 132: Line 132:
 
** (njohnston) This is an FYI that there is an issue with using SIGHUP signals to reload mutable configs
 
** (njohnston) This is an FYI that there is an issue with using SIGHUP signals to reload mutable configs
 
** Fix is in process: https://review.opendev.org/#/c/641907/
 
** Fix is in process: https://review.opendev.org/#/c/641907/
 +
 +
* (rubasov): Adding member actions to a resource that already had member actions, how to?
 +
I have a weird functional test failure in the extraroute-atomic implementation change:
 +
https://zuul.opendev.org/t/openstack/build/8292a52f4ee747b3b754da6da000279b
 +
The router resource had member actions for a long time:
 +
PUT /v2.0/routers/router-id/add_router_interface
 +
PUT /v2.0/routers/router-id/remove_router_interface
 +
The extraroute api-def added two more: https://review.opendev.org/670849
 +
PUT /v2.0/routers/router-id/add_extraroutes
 +
PUT /v2.0/routers/router-id/remove_extraroutes
 +
To my best understanding api-defs of dependent extensions should not be repeated in new api-defs, instead they should be automerged.
 +
All 4 PUT methods above work.
 +
But there's a test neutron.tests.functional.pecan_wsgi.test_controllers.TestRouterController.test_unsupported_method_member_action,
 +
that tries to POST/GET /v2.0/routers/router-id/add_router_interface,
 +
and expects 405 "method not allowed". It did get that before.
 +
But now with the extraroute-atomic api-def the error code changed to 404.
 +
But it again gives 405 if I repeat the PUT add/remove_router_interfaces member actions in the extraroute-atomic api-def.
 +
It's unclear to me what is the expectation on not repeating stuff in api-defs and what's at fault.
 +
Should I just change the test to expect 404 (this is simple but it kind of smells)?
 +
Or should I repeat the PUT add/remove_router_interface member actions in the extraroute-atomic api-def (this is also simple but it's repetitive and I think it is not supposed to be needed)?
 +
Or is this a bug in pecan or in how neutron uses pecan (if this is the agreement I shall sit down and locate the bug)?
  
 
* Topic for the meeting (keep this template, please):
 
* Topic for the meeting (keep this template, please):
 
** (your nickname): brief description.
 
** (your nickname): brief description.
 
*** More details
 
*** More details
 
  
 
== Previous meeting logs ==
 
== Previous meeting logs ==

Revision as of 11:40, 27 August 2019

The OpenStack Networking Team (Neutron) holds public meetings as advertised on OpenStack IRC Meetings Calendar. If you are unable to attend, please check the most recent logs.

Announcements / Reminders

Blueprints

Train-3 blueprints: https://launchpad.net/neutron/+milestone/train-3

Patches up for review:

Community Goals

This slot is to used to track the progress of the community goals. https://governance.openstack.org/tc/goals/index.html#release-cycles

Bugs and Gate issues

Bugs report for week of August 12th: http://lists.openstack.org/pipermail/openstack-discuss/2019-August/008589.html

More discussion on this topic takes place during the Neutron CI meeting: https://wiki.openstack.org/wiki/Meetings/NeutronCI

Bug deputy

You can find more information about what the role is here: https://docs.openstack.org/neutron/latest/contributor/policies/bugs.html#neutron-bug-deputy

During the Denver PTG we made the decision to institute a fixed rotation for the the bugs deputy role. The current scheduled rotation is the following:

Date who note
July-1-2019 Bernard Cafarelli (bcafarel)
July-8-2019 Slawek Kaplonski (slaweq)
July-15-2019 Hongbin Lu (hongbin)
July-22-2019 Boden Russel (boden)
July-29-2019 Brian Haley (haleyb)
August-5-2019 Lajos Katona (lajoskatona) replaced by amotoki for Aug 5
August-12-2019 Ryan Tidwell (tidwellr)
August-19-2019 Swaminathan Vasudevan (Swami)
August-26-2019 Akihiro Motoki (amotoki) replaced by lajoskatona for Aug 26
September-2-2019 Nate Johnston (njohnston)
September-9-2019 Miguel Lavalle (mlavalle)
September-16-2019 YAMAMOTO Takashi (yamamoto)
September-23-2019 Bence Romsics (rubasov)

In preparation for their duty week, deputies are encouraged to review the Neutron bugs policy: https://docs.openstack.org/neutron/latest/contributor/policies/bugs.html

Docs

CLI/SDK

SDK migration of neutronclient python bindings https://etherpad.openstack.org/p/neutron-openstacksdk-migration

Status of changes to deliver OSC (this needs to be revisit)

Neutron-lib, planned refactoring and other impacts

HOUSE KEEPING

PATCHES THAT NEED REVIEWS

On Demand Agenda

We can only pick one or two topics we can talk in the time left of the meeting. People should add ideas to the topics section. We will select one or two topics we can chew during the next meeting. Please follow the template below:

  • From the Oslo team: SIGHUP causing process restart when mutating config
  • (rubasov): Adding member actions to a resource that already had member actions, how to?
I have a weird functional test failure in the extraroute-atomic implementation change:
https://zuul.opendev.org/t/openstack/build/8292a52f4ee747b3b754da6da000279b
The router resource had member actions for a long time:
PUT /v2.0/routers/router-id/add_router_interface
PUT /v2.0/routers/router-id/remove_router_interface
The extraroute api-def added two more: https://review.opendev.org/670849
PUT /v2.0/routers/router-id/add_extraroutes
PUT /v2.0/routers/router-id/remove_extraroutes
To my best understanding api-defs of dependent extensions should not be repeated in new api-defs, instead they should be automerged.
All 4 PUT methods above work.
But there's a test neutron.tests.functional.pecan_wsgi.test_controllers.TestRouterController.test_unsupported_method_member_action,
that tries to POST/GET /v2.0/routers/router-id/add_router_interface,
and expects 405 "method not allowed". It did get that before.
But now with the extraroute-atomic api-def the error code changed to 404.
But it again gives 405 if I repeat the PUT add/remove_router_interfaces member actions in the extraroute-atomic api-def.
It's unclear to me what is the expectation on not repeating stuff in api-defs and what's at fault.
Should I just change the test to expect 404 (this is simple but it kind of smells)?
Or should I repeat the PUT add/remove_router_interface member actions in the extraroute-atomic api-def (this is also simple but it's repetitive and I think it is not supposed to be needed)?
Or is this a bug in pecan or in how neutron uses pecan (if this is the agreement I shall sit down and locate the bug)?
  • Topic for the meeting (keep this template, please):
    • (your nickname): brief description.
      • More details

Previous meeting logs