Jump to: navigation, search


< Horizon
Revision as of 15:47, 1 December 2014 by Rob Cresswell (talk | contribs) (Review Guidelines)

Horizon Code Reviews

This page shares topics related to code reviews related to Horizon (including django-openstack-auth, tuskar-ui).

Please add good references useful for reviews.

Review Links

 title = Horizon Review Inbox
 description = Review Inbox
 foreach = (project:openstack/horizon OR project:openstack/django_openstack_auth OR project:openstack/tuskar-ui) status:open NOT owner:self NOT label:Workflow<=-1 label:Verified>=1,jenkins NOT label:Code-Review>=0,self
 [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"]
 query = NOT label:Code-Review<=2 age:5d
 [section "Your are a reviewer, but haven't voted in the current revision"]
 query = NOT label:Code-Review<=2,self reviewer:self
 [section "Needs final +2"]
 query = label:Code-Review>=2 limit:50
 [section "Passed Jenkins, No Negative Feedback"]
 query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50
 [section "Wayward Changes (Changes with no code review in the last 2days)"]
 query = NOT label:Code-Review<=2 age:2d