Difference between revisions of "Horizon/Reviews"
< Horizon
(→Review Guidelines) |
(→Review Guidelines) |
||
| Line 2: | Line 2: | ||
This page shares topics related to code reviews related to Horizon (including django-openstack-auth, tuskar-ui). | This page shares topics related to code reviews related to Horizon (including django-openstack-auth, tuskar-ui). | ||
| − | |||
| − | |||
Please add good references useful for reviews. | Please add good references useful for reviews. | ||
| − | * OpenStack | + | * [[CodeReviewGuidelines|OpenStack guidelines for code reviewers]]== Review Guidelines == |
| − | * | + | * [http://docs.openstack.org/developer/hacking/ OpenStack Style Guidelines] |
| − | * | + | * [[I18n/TranslatableStrings|i18n]] |
| − | * | + | * [[Horizon/Javascript|Javascript guidelines (in progress)]] |
| − | * Git Commit Messages | + | * [[GitCommitMessages|Git Commit Messages]] |
== Review Links == | == Review Links == | ||
Revision as of 15:47, 1 December 2014
Horizon Code Reviews
This page shares topics related to code reviews related to Horizon (including django-openstack-auth, tuskar-ui).
Please add good references useful for reviews.
- OpenStack guidelines for code reviewers== Review Guidelines ==
- OpenStack Style Guidelines
- i18n
- Javascript guidelines (in progress)
- Git Commit Messages
Review Links
- Direct Links
- Horizon + django-openstack-auth Review Dashboard
- Gerrit Dashboard Creator is useful.
- Dashboard #1
- Generated from Created by https://github.com/stackforge/gerrit-dash-creator/tree/master/dashboards
- Another Review Dashboard (which covers Horizon, django-openstack-auth and tuskar-ui)
- Generated from the dashboard definition below:
[dashboard] title = Horizon Review Inbox description = Review Inbox foreach = (project:openstack/horizon OR project:openstack/django_openstack_auth OR project:openstack/tuskar-ui) status:open NOT owner:self NOT label:Workflow<=-1 label:Verified>=1,jenkins NOT label:Code-Review>=0,self [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] query = NOT label:Code-Review<=2 age:5d [section "Your are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=2,self reviewer:self [section "Needs final +2"] query = label:Code-Review>=2 limit:50 [section "Passed Jenkins, No Negative Feedback"] query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 [section "Wayward Changes (Changes with no code review in the last 2days)"] query = NOT label:Code-Review<=2 age:2d
