Revision as of 18:30, 29 July 2014

Horizon Code Reviews

This page shares topics related to code reviews related to Horizon (including django-openstack-auth, tuskar-ui).

Review Guidelines

Please add good references useful for reviews.

I18N : https://wiki.openstack.org/wiki/I18n/TranslatableStrings

Review Links

Direct Links

Horizon + django-openstack-auth Review Dashboard
- Gerrit Dashboard Creator is useful.
- Dashboard #1
  - Generated from Created by https://github.com/stackforge/gerrit-dash-creator/tree/master/dashboards
- Another Review Dashboard (which covers Horizon, django-openstack-auth and tuskar-ui)
  - Generated from the dashboard definition below:

 [dashboard]
 title = Horizon Review Inbox
 description = Review Inbox
 foreach = (project:openstack/horizon OR project:openstack/django_openstack_auth OR project:openstack/tuskar-ui) status:open NOT owner:self NOT label:Workflow<=-1 label:Verified>=1,jenkins NOT label:Code-Review>=0,self
 
 [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"]
 query = NOT label:Code-Review<=2 age:5d
 
 [section "Your are a reviewer, but haven't voted in the current revision"]
 query = NOT label:Code-Review<=2,self reviewer:self
 
 [section "Needs final +2"]
 query = label:Code-Review>=2 limit:50
 
 [section "Passed Jenkins, No Negative Feedback"]
 query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50
 
 [section "Wayward Changes (Changes with no code review in the last 2days)"]
 query = NOT label:Code-Review<=2 age:2d

@@ Line 17: / Line 17: @@
 * Horizon + django-openstack-auth Review Dashboard
+** [https://github.com/stackforge/gerrit-dash-creator/ Gerrit Dashboard Creator] is useful.
 ** [https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Fhorizon+OR+project%3Aopenstack%2Fdjango_openstack_auth%29+status%3Aopen+NOT+label%3ACode-Review%3C%3D-2&title=Horizon+Review+Dashboard&My+Patches=owner%3Aself+status%3Aopen&Needs+Approval%2C+not+me=NOT+label%3AWorkflow%3E%3D1+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%252cjenkins+NOT+owner%3Aself+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review-1+NOT+label%3ACode-Review%3E%3D1%252cself&Needs+Approval=NOT+label%3AWorkflow%3E%3D1+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%252cjenkins+NOT+owner%3Aself+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review-1&Not+Reviewed+by+Me=NOT+label%3ACode-Review%3C%3D-1%252cself+NOT+label%3ACode-Review%3E%3D1%252cself+limit%3A50&Needs+Reverify=label%3AVerified%3C%3D-1%252cjenkins+branch%3Amaster+NOT+label%3ACode-Review%3C%3D-1+NOT+label%3AWorkflow%3C%3D-1&5+Days+Without+Feedback=NOT+label%3AWorkflow%3E%3D1+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%252cjenkins+NOT+owner%3Aself+NOT+label%3ACode-Review%3C%3D2+age%3A5d&No+Negative+Feedback=NOT+label%3AWorkflow%3E%3D1+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%252cjenkins+NOT+owner%3Aself+NOT+label%3ACode-Review%3C%3D-1+NOT+label%3ACode-Review%3E%3D2+limit%3A50&With+Negative+Feedback=NOT+label%3AWorkflow%3C%3D-1+NOT+label%3AVerified%3C%3D-1%252cjenkins+NOT+owner%3Aself+label%3ACode-Review-1+limit%3A20&Work+In+Progress=NOT+label%3AWorkflow%3E%3D1+NOT+owner%3Aself+label%3AWorkflow%3C%3D-1 Dashboard #1]
 *** Generated from Created by https://github.com/stackforge/gerrit-dash-creator/tree/master/dashboards

Difference between revisions of "Horizon/Reviews"

Revision as of 18:30, 29 July 2014

Horizon Code Reviews

Review Guidelines

Review Links