Difference between revisions of "Horizon/Reviews"
< Horizon
(→Review Guidelines) |
(→Review Links) |
||
| Line 17: | Line 17: | ||
* [https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Fhorizon+OR+project%3Aopenstack%2Fdjango_openstack_auth+OR+project%3Aopenstack%2Ftuskar-ui%29+status%3Aopen+NOT+owner%3Aself+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%252cjenkins+NOT+label%3ACode-Review%3E%3D0%252cself&title=Horizon+Review+Inbox&Needs+Feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29=NOT+label%3ACode-Review%3C%3D2+age%3A5d&Your+are+a+reviewer%2C+but+haven%27t+voted+in+the+current+revision=NOT+label%3ACode-Review%3C%3D2%252cself+reviewer%3Aself&Needs+final+%2B2=label%3ACode-Review%3E%3D2+limit%3A50&Passed+Jenkins%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1+limit%3A50&Wayward+Changes+%28Changes+with+no+code+review+in+the+last+2days%29=NOT+label%3ACode-Review%3C%3D2+age%3A2d Horizon Review Dashboard] (which covers Horizon, django-openstack-auth and tuskar-ui) | * [https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Fhorizon+OR+project%3Aopenstack%2Fdjango_openstack_auth+OR+project%3Aopenstack%2Ftuskar-ui%29+status%3Aopen+NOT+owner%3Aself+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%252cjenkins+NOT+label%3ACode-Review%3E%3D0%252cself&title=Horizon+Review+Inbox&Needs+Feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29=NOT+label%3ACode-Review%3C%3D2+age%3A5d&Your+are+a+reviewer%2C+but+haven%27t+voted+in+the+current+revision=NOT+label%3ACode-Review%3C%3D2%252cself+reviewer%3Aself&Needs+final+%2B2=label%3ACode-Review%3E%3D2+limit%3A50&Passed+Jenkins%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1+limit%3A50&Wayward+Changes+%28Changes+with+no+code+review+in+the+last+2days%29=NOT+label%3ACode-Review%3C%3D2+age%3A2d Horizon Review Dashboard] (which covers Horizon, django-openstack-auth and tuskar-ui) | ||
| − | ** Created by | + | ** Created by https://github.com/stackforge/gerrit-dash-creator/tree/master/dashboards |
** Dashboard definition | ** Dashboard definition | ||
[dashboard] | [dashboard] | ||
Revision as of 17:21, 29 July 2014
Horizon Code Reviews
This page shares topics related to code reviews related to Horizon (including django-openstack-auth, tuskar-ui).
Review Guidelines
Please add good references useful for reviews.
Review Links
- Direct Links
- Horizon Review Dashboard (which covers Horizon, django-openstack-auth and tuskar-ui)
- Created by https://github.com/stackforge/gerrit-dash-creator/tree/master/dashboards
- Dashboard definition
[dashboard] title = Horizon Review Inbox description = Review Inbox foreach = (project:openstack/horizon OR project:openstack/django_openstack_auth OR project:openstack/tuskar-ui) status:open NOT owner:self NOT label:Workflow<=-1 label:Verified>=1,jenkins NOT label:Code-Review>=0,self [section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"] query = NOT label:Code-Review<=2 age:5d [section "Your are a reviewer, but haven't voted in the current revision"] query = NOT label:Code-Review<=2,self reviewer:self [section "Needs final +2"] query = label:Code-Review>=2 limit:50 [section "Passed Jenkins, No Negative Feedback"] query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 [section "Wayward Changes (Changes with no code review in the last 2days)"] query = NOT label:Code-Review<=2 age:2d
