Jump to: navigation, search

Difference between revisions of "Documentation/HowTo/FirstTimers"

(Set up repositories and work locally)
(Set up repositories and work locally)
Line 80: Line 80:
     $ git review -s
     $ git review -s
See Troubleshooting if you have any difficulty with this step.
See [[Documentation/HowTo/FirstTimers|Troubleshoot your Setup]] if you have any difficulty with this step.
In the directory for the cloned repository, check out the master branch and make sure it hasn't changed by pulling updates locally:  
In the directory for the cloned repository, check out the master branch and make sure it hasn't changed by pulling updates locally:  

Revision as of 14:21, 5 February 2015

Step-by-step tutorial

For OpenStack documentation, one of the best places to start is by walking through the install guide and completing it by hand. You can complete a 2-node install with two VMs, for example. Keep notes as you go, offering suggestions for improvement.

Another good first-time docs task is to go to the bugs list at https://bugs.launchpad.net/openstack-manuals/+bugs and look at the new bugs. When you see a doc bug you know how to fix, comment in the bug how to fix the bug. Mark it "Triaged" and give it a status based on the documentation bug triaging guidlines. If you're up for it, you can assign yourself the bug.

Setup with OpenStack Infrastructure

To get started, you must complete the following steps just like any other OpenStack developer. The steps are detailed in the Getting Started section of the Infrastructure Manual and here is an overview:

  1. Create a Launchpad account (which will authenticate as UbuntuOne).
  2. Join the OpenStack Foundation at http://www.openstack.org/join (to see if you joined already, go to http://www.openstack.org/profile)
  3. Sign the Contributor License Agreement (this is part of joining the Foundation above)
  4. Setup git review and get familiar with the Development Workflow, which is shown step-by-step below.

Install Windows prerequisites

If you plan to use Windows to contribute to OpenStack, install these prerequisites:

In the subsequent procedures, run commands from the gitbash command line.

Set up git and git review

Install git. See https://help.github.com/articles/set-up-git. Note: If you installed Windows prerequisites, you already installed git.

Configure git and git review so that they know you:

  $ git config --global user.name "Firstname Lastname"
  $ git config --global user.email name@youremail.com
  $ git config --global gitreview.username yourgerritusername

If you don't remember your Gerrit user name, go to the settings page on gerrit to check it out (it's not your email address).

On your system, install git-review so that you can submit patches:

 curl http://pypi.python.org/packages/source/g/git-review/git-review-1.24.tar.gz -L > git-review.tar.gz
 tar zxvf git-review.tar.gz
 cd git-review-1.24
 python setup.py install
 $ sudo pip install git-review
 $ sudo apt-get install git-review

Set up ssh

On the computer where you will commit, generate an SSH key:

 $ ssh-keygen –t rsa 

Optionally, enter a password. If you enter one, remember it: You must enter it every time you commit.

View and copy your SSH key:

 $ less ~/.ssh/id_rsa.pub

Add your SSH key. See https://review.openstack.org/#/settings/ssh-keys.

Set up repositories and work locally

Note: Documentation is in openstack/openstack-manuals mostly, so this walkthrough uses that repo as the example. You can also substitute openstack/api-site, openstack/operations-guide, openstack/security-guide, or openstack/training-guides, or openstack/ha-guide in the steps below.

Clone a repository. For example, clone openstack/openstack-manuals:

 $ git clone git://git.openstack.org/openstack/openstack-manuals.git

Change into the directory:

 $ cd openstack-manuals

In the same directory, set up git review:

   $ git review -s

See Troubleshoot your Setup if you have any difficulty with this step.

In the directory for the cloned repository, check out the master branch and make sure it hasn't changed by pulling updates locally:

 $ git checkout master; git remote update; git pull origin master

Assign a bug to yourself, such as. https://bugs.launchpad.net/openstack-manuals/+bug/1252931

Create a new local branch, based on master. You don't have to name it with the bug number but it's helpful:

 $ git checkout -b fix-bug-1252931

Fix the bug in the docs. Read the guide on How to contribute to the documentation, pay attention to the Policies and conventions section, which describes Git commit messages, back port procedures, and other conventions.

Commit the local change:

 $ git commit -a

Edit the commit message, following the guidelines documented at the git commit messages page.

The first time you set up a gerrit remote and try to create a patch for review.openstack.org you may see this message:

! [remote rejected] HEAD -> refs/publish/master/addopenstackdocstheme (missing Change-Id in commit message footer)

When this happens, run git commit -a --amend, then save the commit message again and run git review -v again.

Create a patch for review.openstack.org with:

 $ git review -v

Copy and paste the URL returned from git review to take a look:


Celebrate and wait for reviews.

Respond to requests

After you submit a patch, reviewers might ask you to make changes before they approve the patch.

To submit changes to your patch, copy the unique patch number from review.openstack.org. For example, copy nnnnn from the following URL:


At the command line, change into your local copy of the repository. For example:

 $ cd openstack-manuals

To check out the patch, enter:

 $ git review -d nnnnn 

Where nnnnn is the review number that you copied from review.openstack.org.

Make your edits.

In your local copy of the repository:

 $ git commit -a --amend

Then push to review.openstack.org again:

 $ git review -v

Wait for more reviews.

Troubleshoot your setup

git and git review

The first time that you run git review, you might see this error:

   The authenticity of host '[review.openstack.org]:29418 ([]:29418) can't be established.

Type yes (all three letters) at the prompt.

When you connect to gerrit for the first time, you might see this error:

   Could not connect to gerrit.
   Enter your gerrit username: 

Enter the user name that matches the user name in review.openstack.org in Settings.

If you see this error:

   fatal: Not a git repository (or any of the parent directories): .git

You are not in a directory that is a git repository: A .git file was not found.

Change into your local copy of the repository and re-run the command.

If you see this error:

    We don't know where your gerrit is. Please manually create a remote named "gerrit" and try again. 

You need to make a git remote that maps to the review.openstack.org ssh port for your repo. For an example for a username annegentle and the openstack-manuals repo, you'd run this command:

   git remote add gerrit ssh://annegentle@review.openstack.org:29418/openstack/openstack-manuals.git


If your network connection is weak, you might see this error:

   Read from socket failed: Connection reset by peer

Try again when your network connection improves.


If you see this this error:

   /usr/bin/env: python: No such file or directory

Your Python environment is not set up correctly. See the Python documentation for your operating system.