Jump to: navigation, search

Difference between revisions of "Consistent and Secure Default Policies Popup Team"

(Team Design Documents)
(Communication)
 
(35 intermediate revisions by 6 users not shown)
Line 15: Line 15:
 
This team will be disbanded after:
 
This team will be disbanded after:
  
# The barbican, nova, neutron, cinder, and cyborg projects have completed their policy migrations
+
# The majority of the projects listed below have completed their policy migrations
 
# A document is published detailing any pitfalls, lessons learned, and best practices that other teams should be aware of
 
# A document is published detailing any pitfalls, lessons learned, and best practices that other teams should be aware of
 
# A community goal is proposed and accepted by the TC
 
# A community goal is proposed and accepted by the TC
Line 21: Line 21:
 
== Communication ==
 
== Communication ==
  
Use topic:policy-popup in Gerrit.
+
Use topic:secure-rbac in Gerrit.
  
 
Use subject tag [policy] for mailing list discussions.
 
Use subject tag [policy] for mailing list discussions.
  
 
Use #openstack-dev for synchronous discussions.
 
Use #openstack-dev for synchronous discussions.
 +
 +
== Meeting ==
 +
The Secure Default Policies popup team holds public biweekly meeting:
 +
 +
* Channel: #openstack-meeting
 +
* Time: Thursday biweekly-even at 18:00 UTC.
 +
* icall - http://eavesdrop.openstack.org/#Secure_Default_Policies_Popup-Team_Meeting
 +
 +
Everyone interested in the Secure Default Policies and planning to implement those in your project should attend!
 +
 +
=== Agenda ===
 +
 +
https://etherpad.opendev.org/p/default-policy-meeting-agenda
  
 
== Leads ==
 
== Leads ==
  
# Colleen Murphy <colleen@gazlene.net> (cmurphy) [Seeking a replacement]
+
# Raildo Mascena <rmascena@redhat.com> (raildo)
 
# Ghanshyam Mann <gmann@ghanshyammann.com> (gmann)
 
# Ghanshyam Mann <gmann@ghanshyammann.com> (gmann)
  
Line 38: Line 51:
 
* Neutron: Miguel Lavalle (mlavalle)
 
* Neutron: Miguel Lavalle (mlavalle)
 
* Cinder: Brian Rosmaita (rosmaita)
 
* Cinder: Brian Rosmaita (rosmaita)
* Cyborg: Zhipeng (Howard) Huang (zhipeng)
+
* Cyborg: Yumeng Bao (yumeng_bao@yahoo.com)
 +
* Manila: Goutham Pacha Ravi (gouthamr)
  
 
== Members ==
 
== Members ==
Line 51: Line 65:
 
* Erik McCormick <emccormick@cirrusseven.com> (emccormick)
 
* Erik McCormick <emccormick@cirrusseven.com> (emccormick)
 
* Tergel Munkhbat tergel@fibo.cloud
 
* Tergel Munkhbat tergel@fibo.cloud
* Ghanshyam Mann (gmann): Nova, QA adopt testing for the new roles.
+
* Ghanshyam Mann (gmann)
 
* Vishakha Agarwal (vishakha)-  Keystone
 
* Vishakha Agarwal (vishakha)-  Keystone
  
== Team Design Documents ==
+
== Pre-work to provide a smooth migration path to the new policy ==
 +
 
 +
* Migrate Default Policy Format from JSON to YAML (All projects)
 +
** Reference links
 +
*** https://blueprints.launchpad.net/oslo.policy/+spec/policy-json-to-yaml
 +
*** https://specs.openstack.org/openstack/oslo-specs/specs/victoria/policy-json-to-yaml.html
 +
*** https://review.opendev.org/#/q/topic:bp/policy-json-to-yaml+(status:open+OR+status:merged)
 +
** what projects need to do:
 +
*** 1st item in this [https://specs.openstack.org/openstack/oslo-specs/specs/victoria/policy-json-to-yaml.html#work-items Work Items list]
 +
*** Example of Nova: https://review.opendev.org/#/c/748059/
 +
 
 +
* Improving documentation about target resources (oslo.policy)
 +
** https://bugs.launchpad.net/oslo.policy/+bug/1886857
 +
**https://review.opendev.org/#/c/743318/
  
=== Keystone (completed; use as a reference) ===
+
== Team Progress ==
  
* http://specs.openstack.org/openstack/keystone-specs/specs/keystone/ongoing/policy-goals-and-roadmap.html
+
=== Keystone (COMPLETED; use as a reference) ===
* https://bugs.launchpad.net/keystone/+bugs?field.status%3Alist=FIXRELEASED&field.tag=default-roles+system-scope&field.tags_combinator=ANY
 
  
=== Barbican ===
+
* Reference links
 +
** http://specs.openstack.org/openstack/keystone-specs/specs/keystone/ongoing/policy-goals-and-roadmap.html
 +
** https://bugs.launchpad.net/keystone/+bugs?field.status%3Alist=FIXRELEASED&field.tag=default-roles+system-scope&field.tags_combinator=ANY
 +
** Keystone PTG Victoria: https://etherpad.opendev.org/p/victoria-ptg-keystone
  
* https://wiki.openstack.org/wiki/Barbican/Policy
+
=== Nova (COMPLETED; use as a reference) ===
 +
 
 +
* Reference links
 +
** https://specs.openstack.org/openstack/nova-specs/specs/ussuri/approved/policy-defaults-refresh.html
 +
** https://blueprints.launchpad.net/nova/+spec/policy-defaults-refresh-deprecated-apis
 +
** Nova PTG Victoria: https://etherpad.opendev.org/p/nova-victoria-ptg
  
=== Nova ===
+
=== Cyborg (COMPLETED) ===
  
* https://specs.openstack.org/openstack/nova-specs/specs/ussuri/approved/policy-defaults-refresh.html
+
* Reference links
 +
** https://wiki.openstack.org/wiki/Cyborg/Policy
 +
** https://review.opendev.org/699099
 +
** https://storyboard.openstack.org/#!/story/2007024
 +
** https://review.opendev.org/#/q/topic:policy-popup+(status:open+OR+status:merged)
 +
** P0: A full framework with basic policies and one API policy as an example(called device_profile policy): https://review.opendev.org/#/c/740542/
  
=== Neutron ===
+
=== Barbican (not started) ===
  
none yet
+
* https://wiki.openstack.org/wiki/Barbican/Policy
 +
* PTG Victoria discussion: https://etherpad.opendev.org/p/victoria-ptg-barbican
  
=== Cinder ===
+
=== Neutron (not started) ===
  
none yet
+
* Reference links
 +
** https://etherpad.opendev.org/p/neutron-victoria-ptg
  
=== Cyborg ===
+
=== Cinder (not started) ===
  
 
none yet
 
none yet
  
== Progress ==
+
=== Manila (not started) ===
  
TBD - each project may have its own tracking mechanism, to be linked here
+
* Reference links
 +
* Manila PTG Victoria: https://etherpad.opendev.org/p/manila-todos
  
 
== Reviews ==
 
== Reviews ==
Line 93: Line 135:
 
* All about scopes: https://docs.openstack.org/keystone/latest/contributor/services.html#authorization-scopes
 
* All about scopes: https://docs.openstack.org/keystone/latest/contributor/services.html#authorization-scopes
 
* Default roles and scopes: https://docs.openstack.org/keystone/latest/admin/service-api-protection.html
 
* Default roles and scopes: https://docs.openstack.org/keystone/latest/admin/service-api-protection.html
 +
* Migration steps: https://etherpad.openstack.org/p/policy-migration-steps
 +
* Tool to test custom policy : https://pagure.io/openstack-access-policy

Latest revision as of 18:14, 10 December 2020

Problem Description

Existing policy defaults suffer from three major faults:

  1. the admin-ness problem: use of policy rules like 'is_admin' or hard-coded is-admin checks results in the admin-anywhere-admin-everywhere problem and drastically inhibits true multi-tenancy since by default customers cannot have admin rights on their own projects or domains
  2. insecure custom roles: many policy rules simply use "" as the rule, which means there is no rule: anyone can perform that action. This means creation of a custom role (say, "nova-autoscaler" requires editing every policy file across every service to block users with such a rule from performing actions unrelated to their role
  3. related to #2, no support for read-only roles: keystone now has a "reader" role that comes out of the box when keystone is bootstrapped, but it currently has very little value because of the use of empty rules in service policies: users with the "reader" role can still perform write actions on services if the policy rule for such an action is empty.

Team Goal

The keystone project has migrated all of its default policies to 1) use oslo.policy's scope_types attribute, which allows the policy engine to understand "system scope" and distinguish between an admin role assignment on a project versus an admin role assignment on the entire system, 2) ensure all rules use one of the default roles (admin, member, and reader) which both ensures support for a read-only role and prevents custom roles from accidental over-permissiveness. Although the problems being solved are slightly different, the keystone team found it was easiest to migrate everything at once. The rest of the OpenStack services can use this migration as a template for securing their own policies.

Popup Team Completion Criteria

This team will be disbanded after:

  1. The majority of the projects listed below have completed their policy migrations
  2. A document is published detailing any pitfalls, lessons learned, and best practices that other teams should be aware of
  3. A community goal is proposed and accepted by the TC

Communication

Use topic:secure-rbac in Gerrit.

Use subject tag [policy] for mailing list discussions.

Use #openstack-dev for synchronous discussions.

Meeting

The Secure Default Policies popup team holds public biweekly meeting:

Everyone interested in the Secure Default Policies and planning to implement those in your project should attend!

Agenda

https://etherpad.opendev.org/p/default-policy-meeting-agenda

Leads

  1. Raildo Mascena <rmascena@redhat.com> (raildo)
  2. Ghanshyam Mann <gmann@ghanshyammann.com> (gmann)

Liaisons

  • Barbican: Douglas Mendizábal (redrobot)
  • Nova: Ghanshyam Mann (gmann)
  • Neutron: Miguel Lavalle (mlavalle)
  • Cinder: Brian Rosmaita (rosmaita)
  • Cyborg: Yumeng Bao (yumeng_bao@yahoo.com)
  • Manila: Goutham Pacha Ravi (gouthamr)

Members

  • Mohammed Naser <mnaser@vexxhost.com>
  • Douglas Mendizábal (IRC: redrobot) - Barbican - We're supere interested in getting this implemented for Barbican
  • Ade Lee (ade_lee) - barbican
  • Miguel Lavalle (mlavalle) - neutron
  • Chandan Kumar (chandankumar/raukadah)<chkumar@redhat.com> - Help on Tempest and Patrole side
  • Akihiro Motoki (amotoki) - horizon (horizon needs to support the new mechanism of policy definitions. It is different from server side support, so the team needs to explore its own way)
  • Tobias Rydberg (tobberydberg)
  • Erik McCormick <emccormick@cirrusseven.com> (emccormick)
  • Tergel Munkhbat tergel@fibo.cloud
  • Ghanshyam Mann (gmann)
  • Vishakha Agarwal (vishakha)-  Keystone

Pre-work to provide a smooth migration path to the new policy

Team Progress

Keystone (COMPLETED; use as a reference)

Nova (COMPLETED; use as a reference)

Cyborg (COMPLETED)

Barbican (not started)

Neutron (not started)

Cinder (not started)

none yet

Manila (not started)

Reviews

https://review.opendev.org/#/q/is:open+topic:policy-popup

References